Move theme-init.js to assets/ (#3176)

Closes #3175

`theme-init.js` was in `public/` at the root, so it ended up at
`dist/theme-init.js`. In production, Nexus
[serves](https://github.com/oxidecomputer/omicron/blob/b2b1e393a4072f041ee833656fcd57e683704d0e/nexus/src/external_api/console_api.rs#L409-L439)
console static files via explicitly defined routes — there's a
`/assets/{path:.*}` route but no route for files at the root like
`/theme-init.js`.

The fix moves `theme-init.js` from `public/` to `public/assets/` so it
lands in `dist/assets/` and is served by the existing
`/assets/{path:.*}` route. The Vite plugin now references
`/assets/theme-init.js?v={hash}`.

Author: david-crespo

app/api/__tests__/safety.spec.ts

@@ -83,6 +83,18 @@ it('e2e tests are only in test/e2e or test/visual', () => {
   }
 })
 
+// In production, Nexus only serves /assets/* and /index.html — files at other
+// paths under public/ would work in Vite dev but 404 in production.
+// https://github.com/oxidecomputer/omicron/blob/b2b1e39/nexus/src/external_api/console_api.rs#L409-L439
+it('public/ only contains assets/', () => {
+  const entries = fs.readdirSync(path.resolve(__dirname, '../../../public'))
+  expect(entries).toMatchInlineSnapshot(`
+    [
+      "assets",
+    ]
+  `)
+})
+
 // 8-4-4-4-12 hex digits
 const UUID_RE = '[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}'
 

public/theme-init.js public/assets/theme-init.jspublic/theme-init.js renamed to public/assets/theme-init.js

@@ -133,21 +133,21 @@ export default defineConfig(({ mode }) => ({
     },
     {
       // Inject theme-init.js as a classic (non-module) render-blocking script
-      // so it sets data-theme before first paint. It lives in public/ so it
-      // passes CSP default-src 'self'. We inject it here rather than putting
-      // it in index.html because Vite tries to bundle any <script src> it finds
-      // there. Content hash query param handles cache-busting since public/
-      // files aren't fingerprinted by Vite. We cache static assets for a year,
-      // so we need the hash.
+      // so it sets data-theme before first paint. It lives in public/assets/
+      // so it passes CSP default-src 'self' and is served by the /assets/*
+      // route in Nexus. We inject it here rather than putting it in index.html
+      // because Vite tries to bundle any <script src> it finds there. Content
+      // hash query param handles cache-busting since public/ files aren't
+      // fingerprinted by Vite.
       name: 'theme-init',
       transformIndexHtml() {
-        const content = readFileSync(resolve(__dirname, 'public/theme-init.js'))
+        const content = readFileSync(resolve(__dirname, 'public/assets/theme-init.js'))
         const hash = createHash('sha256').update(content).digest('hex').slice(0, 8)
         return [
           {
             injectTo: 'head-prepend',
             tag: 'script',
-            attrs: { src: `/theme-init.js?v=${hash}` },
+            attrs: { src: `/assets/theme-init.js?v=${hash}` },
           },
         ]
       },