prevents an overflowing subtraction when using JLink

benbrittain · benbrittain · commit ed12148179ed · 2022-04-03T19:24:05.000-04:00
diff --git a/humility-core/src/core.rs b/humility-core/src/core.rs
@@ -593,7 +593,9 @@ impl GDBCore {
             // We are done when we have our closing delimter followed by
             // the two byte checksum.
             //
-            if result.find(GDB_PACKET_END) == Some(result.len() - 3) {
+            if result.len() >= 3
+                && result.find(GDB_PACKET_END) == Some(result.len() - 3)
+            {
                 break;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -593,7 +593,9 @@ impl GDBCore {`
`593`	`593`	`// We are done when we have our closing delimter followed by`
`594`	`594`	`// the two byte checksum.`
`595`	`595`	`//`
`596`		`- if result.find(GDB_PACKET_END) == Some(result.len() - 3) {`
	`596`	`+ if result.len() >= 3`
	`597`	`+ && result.find(GDB_PACKET_END) == Some(result.len() - 3)`
	`598`	`+ {`
`597`	`599`	`break;`
`598`	`600`	`}`
`599`	`601`	`}`