prevents an overflowing subtraction when using JLink

benbrittain · benbrittain · commit ff53a75b5fec · 2022-09-21T11:15:38.000-04:00
diff --git a/humility-core/src/core.rs b/humility-core/src/core.rs
@@ -851,7 +851,9 @@ impl GDBCore {
             // We are done when we have our closing delimter followed by
             // the two byte checksum.
             //
-            if result.find(GDB_PACKET_END) == Some(result.len() - 3) {
+            if result.len() >= 3
+                && result.find(GDB_PACKET_END) == Some(result.len() - 3)
+            {
                 break;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -851,7 +851,9 @@ impl GDBCore {`
`851`	`851`	`// We are done when we have our closing delimter followed by`
`852`	`852`	`// the two byte checksum.`
`853`	`853`	`//`
`854`		`- if result.find(GDB_PACKET_END) == Some(result.len() - 3) {`
	`854`	`+ if result.len() >= 3`
	`855`	`+ && result.find(GDB_PACKET_END) == Some(result.len() - 3)`
	`856`	`+ {`
`855`	`857`	`break;`
`856`	`858`	`}`
`857`	`859`	`}`