Bump dependencies, progenitor to d58416b9, oxide.json to omicron:7a911ab4#1438
Merged
Conversation
oxide-reflector-bot
Bot
changed the title
oxide-reflector-bot
Bot
changed the title
ahl
reviewed
May 13, 2026
Comment on lines
+724
to
+729
| CliCommand::PhysicalDiskDisableAdoption => Some("system hardware disk disable-adoption"), | ||
| CliCommand::PhysicalDiskEnableAdoption => Some("system hardware disk enable-adoption"), | ||
| CliCommand::PhysicalDiskListAdoptionRequests => { | ||
| Some("system hardware disk adoption-requests") | ||
| } | ||
| CliCommand::PhysicalDiskListUnadopted => Some("system hardware disk list-unadopted"), |
There was a problem hiding this comment.
Yes! Looks great. Thank you @ahl.
ahl
reviewed
May 13, 2026
Comment on lines
+1812
to
-1841
| let interfaces = current | ||
| .interfaces | ||
| .iter() | ||
| .into_iter() | ||
| .map(|x| SwitchInterfaceConfigCreate { | ||
| link_name: x.interface_name.parse().unwrap(), | ||
| kind: match x.kind { | ||
| SwitchInterfaceKind2::Primary => SwitchInterfaceKind::Primary, | ||
| SwitchInterfaceKind2::Loopback => SwitchInterfaceKind::Loopback, | ||
| SwitchInterfaceKind2::Vlan => { | ||
| todo!("vlan interface outside vlan interfaces?") | ||
| } | ||
| }, | ||
| link_name: x.interface_name, | ||
| kind: x.kind, | ||
| v6_enabled: x.v6_enabled, | ||
| }) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| for v in current.vlan_interfaces.iter() { | ||
| interfaces.push(SwitchInterfaceConfigCreate { | ||
| link_name: format!("vlan-{}", v.vlan_id).parse().unwrap(), | ||
| kind: SwitchInterfaceKind::Vlan(v.vlan_id), | ||
| v6_enabled: false, | ||
| }); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lock file updated
Bump progenitor from
1a5b88f7tod58416b9Changes: oxidecomputer/progenitor@1a5b88f...d58416b
Generated code against nexus-2026050800.0.0-d2276f.json
7a911ab4