Update octorust to use GitHub API Spec 2.1.0

[dave-smith-aus]

There is a newer version of the spec that adds the ability to control new features.

Updating would be greatly appreciated.

[maxammann]

Zoo employee here. This would be super sweet.

Currently generation fails with:

[warn] got ANY kind: Some("requester") installation new permissions accepted event AnySchema { typ: None, pattern: None, multiple_of: None, exclusive_minimum: None, exclusive_maximum: None, minimum: None, maximum: None, properties: {}, required: [], additional_properties: None, min_properties: None, max_properties: None, items: None, min_items: None, max_items: None, unique_items: None, enumeration: [], format: None, min_length: None, max_length: None, one_of: [], all_of: [], any_of: [], not: None }

[warn] got ANY kind: Some("requester") installation suspend event AnySchema { typ: None, pattern: None, multiple_of: None, exclusive_minimum: None, exclusive_maximum: None, minimum: None, maximum: None, properties: {}, required: [], additional_properties: None, min_properties: None, max_properties: None, items: None, min_items: None, max_items: None, unique_items: None, enumeration: [], format: None, min_length: None, max_length: None, one_of: [], all_of: [], any_of: [], not: None }

[warn] got ANY kind: Some("description") webhook installation target renamed account AnySchema { typ: None, pattern: None, multiple_of: None, exclusive_minimum: None, exclusive_maximum: None, minimum: None, maximum: None, properties: {}, required: [], additional_properties: None, min_properties: None, max_properties: None, items: None, min_items: None, max_items: None, unique_items: None, enumeration: [], format: None, min_length: None, max_length: None, one_of: [], all_of: [], any_of: [], not: None }

[warn] got ANY kind: Some("website_url") webhook installation target renamed account AnySchema { typ: None, pattern: None, multiple_of: None, exclusive_minimum: None, exclusive_maximum: None, minimum: None, maximum: None, properties: {}, required: [], additional_properties: None, min_properties: None, max_properties: None, items: None, min_items: None, max_items: None, unique_items: None, enumeration: [], format: None, min_length: None, max_length: None, one_of: [], all_of: [], any_of: [], not: None }

[warn] got ANY kind: Some("requester") installation unsuspend event AnySchema { typ: None, pattern: None, multiple_of: None, exclusive_minimum: None, exclusive_maximum: None, minimum: None, maximum: None, properties: {}, required: [], additional_properties: None, min_properties: None, max_properties: None, items: None, min_items: None, max_items: None, unique_items: None, enumeration: [], format: None, min_length: None, max_length: None, one_of: [], all_of: [], any_of: [], not: None }

Error: we ran out of unique names for this thing issue data type links object: Object({"active_lock_reason": TypeId(2400), "assignee": TypeId(2391), "assignees": TypeId(2401), "author_association": TypeId(330), "body": TypeId(1), "closed_at": TypeId(34), "comments": TypeId(22), "comments_url": TypeId(1), "created_at": TypeId(34), "draft": TypeId(2402), "events_url": TypeId(1), "html_url": TypeId(1), "id": TypeId(22), "labels": TypeId(2404), "labels_url": TypeId(1), "locked": TypeId(2402), "milestone": TypeId(2405), "node_id": TypeId(1), "number": TypeId(22), "performed_via_github_app": TypeId(2419), "pull_request": TypeId(2422), "reactions": TypeId(332), "repository_url": TypeId(1), "state": TypeId(2425), "state_reason": TypeId(2426), "sub_issues_summary": TypeId(2423), "timeline_url": TypeId(2426), "title": TypeId(1), "type": TypeId(349), "updated_at": TypeId(34), "url": TypeId(1), "user": TypeId(2391)}, SchemaData { nullable: false, read_only: false, write_only: false, deprecated: false, external_docs: None, example: None, title: Some("Issue"), description: Some("The [issue](https://docs.github.com/rest/issues/issues#get-an-issue) itself."), discriminator: None, default: None, extensions: {} })
make: *** [github] Error 1
make github  21.84s user 5.17s system 198% cpu 13.601 total

[augustuswm]

I would like to update this, but it is not currently high on my priority list. It may be something I get to later this year, though certainly happy to provide guidance if anyone wants to take this on.

[mbainter]

I was poking at trying to update this tonight and ran into this same thing. In the new spec under components -> schemas it now has (edited for brevity):

      "webhooks_issue_comment": {
        "title": "issue comment",
        "description": "The [comment](https://docs.github.com/rest/issues/comments#get-an-issue-comment) itself.",
        "type": "object",
        "properties": {},
        "required": []
      },
      "webhooks_issue": {
        "title": "Issue",
        "description": "The [issue](https://docs.github.com/rest/issues/issues#get-an-issue) itself.",
        "type": "object",
        "properties": {},
        "required": []
      },
      "webhooks_issue_2": {
        "title": "Issue",
        "description": "The [issue](https://docs.github.com/rest/issues/issues#get-an-issue) itself.",
        "type": "object",
        "properties": {},
        "required": []
      }

and (plus created, deleted):

      "webhook-issue-comment-edited": {
        "title": "issue_comment edited event",
        "type": "object",
        "properties": {},
        "required": []
      }

If I'm reading the generator code correctly, this is resulting in duplicate schemas between the actual Issues API and the webhooks. The debug data threw me, because it implies that it sees a distinction between the two schemas:

SCHEMA 76/907: nullable pinned issue comment
SCHEMA 77/907: issue comment
SCHEMA 583/907: webhooks issue comment
SCHEMA 696/907: webhook issue comment created
SCHEMA 697/907: webhook issue comment deleted
SCHEMA 698/907: webhook issue comment edited

But I threw some extra debug statements in and found that it ends up with names like:

SCHEMA	name
webhooks issue comment	issue comment
webhook issue comment created	issue comment created event data
webhook issue comment deleted	issue comment deleted event issue all of
webhook issue comment edited	Bail

I threw a continue into the loop to skip the webhook items just to see what other issues are lurking in the update. It gets stuck again in paths (specifically pulls_create) but I haven't had time to actually look into this one:

...
pulls_list
        /repos/{owner}/{repo}/pulls GET response body -> Vec<crate::types::PullRequestSimple> TypeId(5693) | TypeId(5141) | TypeId(5138)

pulls_create
Error: XXX unknown string format repo.nwo
make: *** [Makefile:201: github] Error 1

[mbainter]

Had today to myself and was able to set aside some time tonight to come back to this, and the PR above at least has it in a state where it all builds and the core tests pass. @augustuswm if you come by spare time to look it over and have any feedback I should incorporate I welcome it.