Skip to content

Commit f1d311a

Browse files
committed
make more readable
1 parent 3fcc239 commit f1d311a

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

README.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,19 @@ The server now boots up and we can import the StableDiffusion plugin, and even i
2323
The SD plugin processes are being refactored into the job system as JobParameters, which we can extend.
2424
The ProcessResult had too many values being copied around. Instead we are now keeping them in the JobParameters object.
2525

26-
So the plugin announces its capabilities: (name, function, input type, output type, parameter class)
27-
Its function returns one or multiple jobs, each job is created with a job param that describes this action.
28-
and it will work
26+
So the plugin announces its job signatures like this: `name, function, input type, output type, parameter class`
27+
Each invocation function returns one or multiple jobs, and each job has an associated param object to configure it.
2928

30-
A lot of useless UI shit mixed into the backend, we're mostly deleting this code, its effortless to rewrite it.
29+
A lot of useless UI shit mixed into the backend, we're mostly restarting from scartch for the gradio UI.
3130

3231
Contribution points:
3332

34-
- Missing a UI and the Stable Diffusion plugin is in shambles because still refactoring. A lot of the API points are missing for a good UI
35-
- Need to figure out sessions with connection methods like ssh or password, otherwise anyone can use if u share (lol)
3633
- Obviously I am trying to get the SD plugin working first with img2img and txt2img jobs, then all the upscalers are mostly the same.
37-
- Should probably remove a lot of CLI arguments and use an option system instead. Too many commandline args it's a mess.
38-
- Need to figure out how we can get an efficient system where plugins are hosted on github and collect them for listing.
3934
- It would be cool to embed a CLI interface into the server but idk how to do this with flask, I'm using app.run().
35+
- Missing a UI and the Stable Diffusion plugin is in shambles because still refactoring. A lot of the API points are missing for a good UI
36+
- Need to figure out sessions with connection methods like passwords, ssh, etc. otherwise anyone can request jobs if u share (lol)
37+
- Need to figure out how we can get an efficient system where plugins are hosted on github and collect them for listing.
38+
- Removing a lot of cli args and options and using job params where possible
4039

4140
AUTOMATIC1111 is still not responding and I don't know any other way to contact him so don't know if we have him on-board. The project must be renamed to stable-core or something not stable-diffusion related.
4241

0 commit comments

Comments
 (0)