From 2b8ba4f57414b62b60ae481398547dfce1694248 Mon Sep 17 00:00:00 2001 From: Kevin Deldycke Date: Fri, 22 May 2026 09:23:50 +0200 Subject: [PATCH 1/8] Fix quoting, add PR references https://github.com/pallets/click/pull/3493 https://github.com/pallets/click/pull/3482 --- CHANGES.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index 14f575ad5..3a09ce144 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -26,8 +26,8 @@ Released 2026-05-21 - Zsh completion scripts parse correctly on Windows. :issue:`3277` :pr:`3466` - Shell completion of `Choice` `Enum` values produces a valid completion result. :issue:`3015` -- Fix empty byte-string handling in echo. :issue:`3487` -- Fix closed file error with `echo_via_pager`. :issue:`3449` +- Fix empty byte-string handling in echo. :issue:`3487` :pr:`3493` +- Fix closed file error with ``echo_via_pager``. :issue:`3449` :pr:`3482` Version 8.4.0 From bff780ff9df7a8d0a271db2f80c17c7be32dc2a1 Mon Sep 17 00:00:00 2001 From: Kevin Deldycke Date: Fri, 22 May 2026 09:49:59 +0200 Subject: [PATCH 2/8] Fix layout, align full version --- src/click/_termui_impl.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/click/_termui_impl.py b/src/click/_termui_impl.py index 76113e9bb..3336c37c3 100644 --- a/src/click/_termui_impl.py +++ b/src/click/_termui_impl.py @@ -430,8 +430,11 @@ def _pager_contextmanager( @contextlib.contextmanager def get_pager_file(color: bool | None = None) -> t.Generator[t.TextIO, None, None]: """Context manager. + Yields a writable file-like object which can be used as an output pager. - .. versionadded:: 8.4 + + .. versionadded:: 8.4.0 + :param color: controls if the pager supports ANSI colors or not. The default is autodetection. """ From a198674bc46e8c95801c78c6d65b88dc254bdc10 Mon Sep 17 00:00:00 2001 From: Kevin Deldycke Date: Fri, 22 May 2026 10:15:16 +0200 Subject: [PATCH 3/8] Remove empty H1 header Refs: https://github.com/pallets/click/pull/3447 --- docs/index.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/index.md b/docs/index.md index 4549769c2..0f046d8f1 100644 --- a/docs/index.md +++ b/docs/index.md @@ -1,4 +1,8 @@ -# +```{eval-rst} +.. rst-class:: hide-header +``` + +# Welcome to Click ```{image} _static/click-name.svg :align: center From 10f78cdb1df9874a8aa1757102ade4efa6a54732 Mon Sep 17 00:00:00 2001 From: Kevin Deldycke Date: Fri, 22 May 2026 10:27:47 +0200 Subject: [PATCH 4/8] Use MyST syntax --- docs/conf.py | 1 + docs/index.md | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index d04b78327..4842959f5 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -31,6 +31,7 @@ intersphinx_mapping = { "python": ("https://docs.python.org/3/", None), } +myst_enable_extensions = ["attrs_block"] myst_heading_anchors = 3 # HTML ----------------------------------------------------------------- diff --git a/docs/index.md b/docs/index.md index 0f046d8f1..c280b1974 100644 --- a/docs/index.md +++ b/docs/index.md @@ -1,7 +1,4 @@ -```{eval-rst} -.. rst-class:: hide-header -``` - +{.hide-header} # Welcome to Click ```{image} _static/click-name.svg From 9b3fe6b8b43cd242cc200563dfd6425d51909f43 Mon Sep 17 00:00:00 2001 From: Kevin Deldycke Date: Fri, 22 May 2026 10:34:07 +0200 Subject: [PATCH 5/8] Typo Refs: https://github.com/pallets/click/pull/3484 --- CHANGES.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.rst b/CHANGES.rst index 3a09ce144..f6b0ef556 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -22,7 +22,7 @@ Version 8.4.1 Released 2026-05-21 - ``get_parameter_source()`` is available during eager callbacks and type - conversion again. :issue:`3458` :issue:`3484` + conversion again. :issue:`3458` :pr:`3484` - Zsh completion scripts parse correctly on Windows. :issue:`3277` :pr:`3466` - Shell completion of `Choice` `Enum` values produces a valid completion result. :issue:`3015` From c3041c6caf4deadf04c4eccf010ea59922d8007c Mon Sep 17 00:00:00 2001 From: Kevin Deldycke Date: Fri, 22 May 2026 10:35:24 +0200 Subject: [PATCH 6/8] Add missing PR link and update style Ref: #3471 --- CHANGES.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGES.rst b/CHANGES.rst index f6b0ef556..746d47e4a 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -24,8 +24,8 @@ Released 2026-05-21 - ``get_parameter_source()`` is available during eager callbacks and type conversion again. :issue:`3458` :pr:`3484` - Zsh completion scripts parse correctly on Windows. :issue:`3277` :pr:`3466` -- Shell completion of `Choice` `Enum` values produces a valid completion - result. :issue:`3015` +- Shell completion of ``Enum`` values used as ``Choice`` options produces a + valid completion result. :issue:`3015` :pr:`3471` - Fix empty byte-string handling in echo. :issue:`3487` :pr:`3493` - Fix closed file error with ``echo_via_pager``. :issue:`3449` :pr:`3482` From 5eea580808f0b563a79066207dfcbf29669e3896 Mon Sep 17 00:00:00 2001 From: Kevin Deldycke Date: Fri, 22 May 2026 10:40:31 +0200 Subject: [PATCH 7/8] Add missing changelog entry Refs: #2994 and #3478 --- CHANGES.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGES.rst b/CHANGES.rst index 746d47e4a..af8fbd2e4 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -28,6 +28,8 @@ Released 2026-05-21 valid completion result. :issue:`3015` :pr:`3471` - Fix empty byte-string handling in echo. :issue:`3487` :pr:`3493` - Fix closed file error with ``echo_via_pager``. :issue:`3449` :pr:`3482` +- Fix ``open_url`` on Windows when the file path contains spaces. + :issue:`2994` :pr:`3478` Version 8.4.0 From 534761cde3b1ae4877232c42feee063ca68f8480 Mon Sep 17 00:00:00 2001 From: Kevin Deldycke Date: Fri, 22 May 2026 16:21:14 +0200 Subject: [PATCH 8/8] Add missing closing issue ref Refs: https://github.com/pallets/click/issues/2868 --- CHANGES.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.rst b/CHANGES.rst index af8fbd2e4..16508ab04 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -79,7 +79,7 @@ Released 2026-05-17 :pr:`2969` - Use :func:`os.startfile` on Windows to open URLs in :func:`open_url`, replacing the ``start`` built-in which cannot be invoked without - ``shell=True``. :issue:`3164` :pr:`3186` + ``shell=True``. :issue:`2868` :issue:`3164` :pr:`3186` - Fix Fish shell completion errors when option help text contains newlines. :issue:`3043` :pr:`3126` - Add :class:`NoSuchCommand` exception with suggestions for misspelled