Skip to content

Make window-to-win and restore keep track or window-parameters#52

Open
rhuelga wants to merge 2 commits into
pashinin:masterfrom
rhuelga:master
Open

Make window-to-win and restore keep track or window-parameters#52
rhuelga wants to merge 2 commits into
pashinin:masterfrom
rhuelga:master

Conversation

@rhuelga

@rhuelga rhuelga commented Sep 15, 2014

Copy link
Copy Markdown

The window-parameters are not saved, with this modification the parameters contained in the window-persistent-parameters are saved and restored, the way that current-window-configuration does.

@pashinin

Copy link
Copy Markdown
Owner

Modifying these main structures will make everyones' session files broken (when you read an old session file with a new "win" struct) Can you use parameters? http://workgroups2.readthedocs.org/en/latest/guide/data-structures.html#parameters

@rhuelga

rhuelga commented Sep 17, 2014

Copy link
Copy Markdown
Author

Now it use win parameters. and the win struct is not modify.

@pashinin

Copy link
Copy Markdown
Owner

Found another problem...

  1. These parameters (that are saved) may contain complex objects (like #<buffer>). They cannot be saved "as is" like #<buffer> or you will get an error in reading a session file. You can see just a few lines below that I hacked it using (wg-pickel ...) before saving window-next-buffers.
  2. I've met a new object for me for example. #overlay in no buffer. Didn't test anything, maybe it works with wg-pickel. For such sudden errors I used (ignore-errors...)

Have you met these problems?

PS: I know this extension is complex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants