Skip to content

Commit e7024a1

Browse files
committed
add mimic_core view
1 parent 9490a76 commit e7024a1

5 files changed

Lines changed: 23 additions & 20 deletions

File tree

src/pasteur/extras/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def get_recommended_datasets() -> list[Dataset | View]:
1616
from .datasets.mimic import MimicDataset
1717
from .datasets.texas import TexasDataset
1818
from .views.adult import TabAdultView
19-
from .views.mimic import MimicMmCoreView, MimicTabAdmissions
19+
from .views.mimic import MimicCore, MimicTabAdmissions
2020
# from .views.texas import TexasChargesView, TexasBaseView, TexasBillionView
2121

2222
return [
@@ -27,7 +27,7 @@ def get_recommended_datasets() -> list[Dataset | View]:
2727
# TexasChargesView(),
2828
# TexasBaseView(),
2929
TabAdultView(),
30-
# MimicMmCoreView,
30+
# MimicCore,
3131
MimicTabAdmissions(),
3232
# TexasBillionView(),
3333
]

src/pasteur/extras/views/mimic/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ def mm_core_transform_patients(patients: pd.DataFrame):
3030
return patients_new
3131

3232

33-
class MimicMmCoreView(View):
33+
class MimicCore(View):
3434
"""The mimic core tables, slightly post processed."""
3535

36-
name = "mimic_mm_core"
36+
name = "mimic_core"
3737
dataset = "mimic"
3838
deps: dict[str, list[str]] = {
3939
"patients": ["core_patients"],
@@ -44,7 +44,7 @@ class MimicMmCoreView(View):
4444
"admissions": ["patients"],
4545
"transfers": ["admissions"],
4646
}
47-
parameters = get_relative_fn("parameters_mm.yml")
47+
parameters = get_relative_fn("parameters_core.yml")
4848

4949
@to_chunked
5050
def ingest(self, name, **tables: LazyChunk):

src/pasteur/extras/views/mimic/parameters_mm.yml renamed to src/pasteur/extras/views/mimic/parameters_core.yml

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,28 @@ tables:
55
subject_id: id
66
gender: categorical
77
# year_group: categorical
8-
dod: date?:birth_year
8+
dod:
9+
type: date
10+
span: year
11+
ref: birth_year
12+
nullable: True
13+
max_len: 99
14+
bins: 32
915
birth_year: fixed|date
1016

1117
admissions:
1218
primary_key: hadm_id
19+
sequencer: admittime
20+
1321
fields:
1422
hadm_id: id
1523
subject_id: id:patients.subject_id
1624
admittime:
17-
type: datetime
25+
type: seqdatetime
1826
span: year.hour
19-
ref:
20-
table: patients
21-
col: birth_year
27+
ref: patients.birth_year
2228
max_len: 99
23-
bins: 100
29+
bins: 32
2430
dischtime: datetime|day.hour:admittime
2531
deathtime: datetime?|day.hour:admittime
2632
admission_type: categorical
@@ -36,10 +42,11 @@ tables:
3642

3743
transfers:
3844
primary_key: transfer_id
45+
sequencer: intime
3946
fields:
4047
transfer_id: id
4148
hadm_id: id:admissions.hadm_id
4249
eventtype: categorical
4350
careunit: categorical?
44-
intime: datetime|day.hour:admissions.admittime
51+
intime: seqdatetime|day.hour:admissions.admittime
4552
outtime: datetime?|day.hour:intime

src/pasteur/table.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535

3636
A = TypeVar("A", bound="Any")
3737
META = TypeVar("META")
38-
_IDKEY = "__ids_lkjhasndsfnewr"
3938

4039

4140
def _reduce_inner(
@@ -231,13 +230,9 @@ def fit(
231230
tables: dict[str, LazyFrame],
232231
ids: LazyFrame | None = None,
233232
):
234-
if ids is not None:
235-
tables = {_IDKEY: ids, **tables}
236-
237233
per_call = []
238-
for _, chunks in LazyFrame.zip(tables).items():
239-
ids_chunk = chunks.pop(_IDKEY, None)
240-
per_call.append({"ids": ids_chunk, "tables": chunks})
234+
for cids, ctables in LazyFrame.zip_values([ids, tables]):
235+
per_call.append({"ids": cids, "tables": ctables})
241236

242237
transformer_chunks: list[
243238
dict[str | tuple[str], Transformer]

src/project/settings.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,11 @@
5353

5454
from pasteur.extras import get_recommended_modules
5555
from pasteur.extras.synth.pgm import AIM, MST
56-
from pasteur.extras.views.mimic import MimicBillion
56+
from pasteur.extras.views.mimic import MimicBillion, MimicCore
5757

5858
PASTEUR_MODULES = get_recommended_modules() + [
5959
AIM.get_factory(),
6060
MST.get_factory(),
6161
MimicBillion(),
62+
MimicCore(),
6263
]

0 commit comments

Comments
 (0)