Skip to content
This repository was archived by the owner on Apr 15, 2026. It is now read-only.

Commit 9e6279a

Browse files
authored
Merge pull request #23 from patrickcping/fix-double-quote-connector-vars-202412
Fix double quoted string connector variables
2 parents 5f773ed + 553b8ed commit 9e6279a

3 files changed

Lines changed: 34 additions & 29 deletions

File tree

example/output/davinci_connectors.tf

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -47,19 +47,19 @@ resource "davinci_connection" "flowconnector__2581eb287bb1d9bd29ae9886d675f89f"
4747
var.davinci_connection_flowconnector__2581eb287bb1d9bd29ae9886d675f89f_enforcedSignedToken != null ? [{
4848
name = "enforcedSignedToken"
4949
type = "boolean"
50-
value = jsonencode(var.davinci_connection_flowconnector__2581eb287bb1d9bd29ae9886d675f89f_enforcedSignedToken)
50+
value = tostring(var.davinci_connection_flowconnector__2581eb287bb1d9bd29ae9886d675f89f_enforcedSignedToken)
5151
}] : [],
5252
// Input Schema
5353
var.davinci_connection_flowconnector__2581eb287bb1d9bd29ae9886d675f89f_inputSchema != null ? [{
5454
name = "inputSchema"
5555
type = "string"
56-
value = jsonencode(var.davinci_connection_flowconnector__2581eb287bb1d9bd29ae9886d675f89f_inputSchema)
56+
value = tostring(var.davinci_connection_flowconnector__2581eb287bb1d9bd29ae9886d675f89f_inputSchema)
5757
}] : [],
5858
// Public Key
5959
var.davinci_connection_flowconnector__2581eb287bb1d9bd29ae9886d675f89f_pemPublicKey != null ? [{
6060
name = "pemPublicKey"
6161
type = "string"
62-
value = jsonencode(var.davinci_connection_flowconnector__2581eb287bb1d9bd29ae9886d675f89f_pemPublicKey)
62+
value = tostring(var.davinci_connection_flowconnector__2581eb287bb1d9bd29ae9886d675f89f_pemPublicKey)
6363
}] : [],
6464

6565
)
@@ -84,19 +84,19 @@ resource "davinci_connection" "flowconnector__33329a264e268ab31fb19637debf1ea3"
8484
var.davinci_connection_flowconnector__33329a264e268ab31fb19637debf1ea3_enforcedSignedToken != null ? [{
8585
name = "enforcedSignedToken"
8686
type = "boolean"
87-
value = jsonencode(var.davinci_connection_flowconnector__33329a264e268ab31fb19637debf1ea3_enforcedSignedToken)
87+
value = tostring(var.davinci_connection_flowconnector__33329a264e268ab31fb19637debf1ea3_enforcedSignedToken)
8888
}] : [],
8989
// Input Schema
9090
var.davinci_connection_flowconnector__33329a264e268ab31fb19637debf1ea3_inputSchema != null ? [{
9191
name = "inputSchema"
9292
type = "string"
93-
value = jsonencode(var.davinci_connection_flowconnector__33329a264e268ab31fb19637debf1ea3_inputSchema)
93+
value = tostring(var.davinci_connection_flowconnector__33329a264e268ab31fb19637debf1ea3_inputSchema)
9494
}] : [],
9595
// Public Key
9696
var.davinci_connection_flowconnector__33329a264e268ab31fb19637debf1ea3_pemPublicKey != null ? [{
9797
name = "pemPublicKey"
9898
type = "string"
99-
value = jsonencode(var.davinci_connection_flowconnector__33329a264e268ab31fb19637debf1ea3_pemPublicKey)
99+
value = tostring(var.davinci_connection_flowconnector__33329a264e268ab31fb19637debf1ea3_pemPublicKey)
100100
}] : [],
101101

102102
)
@@ -130,25 +130,25 @@ resource "davinci_connection" "httpconnector__867ed4363b2bc21c860085ad2baa817d"
130130
var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_connectionId != null ? [{
131131
name = "connectionId"
132132
type = "string"
133-
value = jsonencode(var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_connectionId)
133+
value = tostring(var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_connectionId)
134134
}] : [],
135135
// reCAPTCHA v2 Secret Key
136136
var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_recaptchaSecretKey != null ? [{
137137
name = "recaptchaSecretKey"
138138
type = "string"
139-
value = jsonencode(var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_recaptchaSecretKey)
139+
value = tostring(var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_recaptchaSecretKey)
140140
}] : [],
141141
// reCAPTCHA v2 Site Key
142142
var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_recaptchaSiteKey != null ? [{
143143
name = "recaptchaSiteKey"
144144
type = "string"
145-
value = jsonencode(var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_recaptchaSiteKey)
145+
value = tostring(var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_recaptchaSiteKey)
146146
}] : [],
147147
// Trusted Sites
148148
var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_whiteList != null ? [{
149149
name = "whiteList"
150150
type = "string"
151-
value = jsonencode(var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_whiteList)
151+
value = tostring(var.davinci_connection_httpconnector__867ed4363b2bc21c860085ad2baa817d_whiteList)
152152
}] : [],
153153

154154
)
@@ -191,31 +191,31 @@ resource "davinci_connection" "notificationsconnector__cacf3d2861657174d93cbf445
191191
var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_clientId != null ? [{
192192
name = "clientId"
193193
type = "string"
194-
value = jsonencode(var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_clientId)
194+
value = tostring(var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_clientId)
195195
}] : [],
196196
// Client Secret
197197
var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_clientSecret != null ? [{
198198
name = "clientSecret"
199199
type = "string"
200-
value = jsonencode(var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_clientSecret)
200+
value = tostring(var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_clientSecret)
201201
}] : [],
202202
// Environment ID
203203
var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_envId != null ? [{
204204
name = "envId"
205205
type = "string"
206-
value = jsonencode(var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_envId)
206+
value = tostring(var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_envId)
207207
}] : [],
208208
// Notification Policy ID
209209
var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_notificationPolicyId != null ? [{
210210
name = "notificationPolicyId"
211211
type = "string"
212-
value = jsonencode(var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_notificationPolicyId)
212+
value = tostring(var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_notificationPolicyId)
213213
}] : [],
214214
// Region
215215
var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_region != null ? [{
216216
name = "region"
217217
type = "string"
218-
value = jsonencode(var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_region)
218+
value = tostring(var.davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_region)
219219
}] : [],
220220

221221
)
@@ -249,31 +249,31 @@ resource "davinci_connection" "pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9
249249
var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_clientId != null ? [{
250250
name = "clientId"
251251
type = "string"
252-
value = jsonencode(var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_clientId)
252+
value = tostring(var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_clientId)
253253
}] : [],
254254
// Client Secret
255255
var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_clientSecret != null ? [{
256256
name = "clientSecret"
257257
type = "string"
258-
value = jsonencode(var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_clientSecret)
258+
value = tostring(var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_clientSecret)
259259
}] : [],
260260
// Environment ID
261261
var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_envId != null ? [{
262262
name = "envId"
263263
type = "string"
264-
value = jsonencode(var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_envId)
264+
value = tostring(var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_envId)
265265
}] : [],
266266
// Policy ID
267267
var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_policyId != null ? [{
268268
name = "policyId"
269269
type = "string"
270-
value = jsonencode(var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_policyId)
270+
value = tostring(var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_policyId)
271271
}] : [],
272272
// Region
273273
var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_region != null ? [{
274274
name = "region"
275275
type = "string"
276-
value = jsonencode(var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_region)
276+
value = tostring(var.davinci_connection_pingonemfaconnector__b72bd44e6be8180bd5988ac74cd9c949_region)
277277
}] : [],
278278

279279
)
@@ -298,25 +298,25 @@ resource "davinci_connection" "pingoneriskconnector__292873d5ceea806d81373ed0341
298298
var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_clientId != null ? [{
299299
name = "clientId"
300300
type = "string"
301-
value = jsonencode(var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_clientId)
301+
value = tostring(var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_clientId)
302302
}] : [],
303303
// Client Secret
304304
var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_clientSecret != null ? [{
305305
name = "clientSecret"
306306
type = "string"
307-
value = jsonencode(var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_clientSecret)
307+
value = tostring(var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_clientSecret)
308308
}] : [],
309309
// Environment ID
310310
var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_envId != null ? [{
311311
name = "envId"
312312
type = "string"
313-
value = jsonencode(var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_envId)
313+
value = tostring(var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_envId)
314314
}] : [],
315315
// Region
316316
var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_region != null ? [{
317317
name = "region"
318318
type = "string"
319-
value = jsonencode(var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_region)
319+
value = tostring(var.davinci_connection_pingoneriskconnector__292873d5ceea806d81373ed0341b5c88_region)
320320
}] : [],
321321

322322
)
@@ -341,25 +341,25 @@ resource "davinci_connection" "pingonessoconnector__94141bf2f1b9b59a5f5365ff135e
341341
var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_clientId != null ? [{
342342
name = "clientId"
343343
type = "string"
344-
value = jsonencode(var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_clientId)
344+
value = tostring(var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_clientId)
345345
}] : [],
346346
// Client Secret
347347
var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_clientSecret != null ? [{
348348
name = "clientSecret"
349349
type = "string"
350-
value = jsonencode(var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_clientSecret)
350+
value = tostring(var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_clientSecret)
351351
}] : [],
352352
// Environment ID
353353
var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_envId != null ? [{
354354
name = "envId"
355355
type = "string"
356-
value = jsonencode(var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_envId)
356+
value = tostring(var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_envId)
357357
}] : [],
358358
// Region
359359
var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_region != null ? [{
360360
name = "region"
361361
type = "string"
362-
value = jsonencode(var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_region)
362+
value = tostring(var.davinci_connection_pingonessoconnector__94141bf2f1b9b59a5f5365ff135e02bb_region)
363363
}] : [],
364364

365365
)

internal/generate/templates/0.4/hcl_davinci_connection.tf.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ resource "davinci_connection" "{{.ResourceName}}" {
1212
var.davinci_connection_{{$resourcename}}_{{$property.Name}} != null ? [{
1313
name = "{{$property.Name}}"
1414
type = "{{$property.ProviderType}}"
15-
value = jsonencode(var.davinci_connection_{{$resourcename}}_{{$property.Name}})
15+
value = tostring(var.davinci_connection_{{$resourcename}}_{{$property.Name}})
1616
}] : [],
1717
{{end}}
1818
)

testing/test-cases/ciam-passwordless-flow-pack/general.tftest.hcl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,11 @@ run "apply_success" {
156156

157157
variables {
158158
pingone_environment_id = run.pingone_setup.pingone_environment_id
159+
160+
davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_envId = run.pingone_setup.pingone_environment_id
161+
davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_clientId = run.pingone_setup.pingone_application_client_id
162+
davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_clientSecret = run.pingone_setup.pingone_application_client_secret
163+
davinci_connection_notificationsconnector__cacf3d2861657174d93cbf445d55797a_region = run.pingone_setup.pingone_region_code
159164
}
160165

161166
module {

0 commit comments

Comments
 (0)