Resolve code scanning errors #2

patrickcping · patrickcping · commit e3c6f941b0a5 · 2025-02-06T10:48:30.000Z
diff --git a/internal/generate/generate.go b/internal/generate/generate.go
@@ -846,7 +846,7 @@ func (d *DaVinciGenerator) writeAssets() error {
 
 	outputDir := fmt.Sprintf("%s/assets/flows/", d.outputPath)
 
-	err := os.MkdirAll(outputDir, os.ModePerm)
+	err := os.MkdirAll(outputDir, 0750)
 	if err != nil {
 		return fmt.Errorf("failed to create directory %q. err: %s", outputDir, err.Error())
 	}
@@ -868,7 +868,7 @@ func (d *DaVinciGenerator) writeAsset(flowAsset flowAssetData) error {
 		return fmt.Errorf("Cannot marshal asset data: %s", err)
 	}
 
-	err = os.WriteFile(fmt.Sprintf("%s/%s", d.outputPath, flowAsset.path), fileData, 0644)
+	err = os.WriteFile(fmt.Sprintf("%s/%s", d.outputPath, flowAsset.path), fileData, 0600)
 	if err != nil {
 		return fmt.Errorf("Cannot write asset file %s: %s", flowAsset.path, err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -846,7 +846,7 @@ func (d *DaVinciGenerator) writeAssets() error {`
`846`	`846`
`847`	`847`	`outputDir := fmt.Sprintf("%s/assets/flows/", d.outputPath)`
`848`	`848`
`849`		`- err := os.MkdirAll(outputDir, os.ModePerm)`
	`849`	`+ err := os.MkdirAll(outputDir, 0750)`
`850`	`850`	`if err != nil {`
`851`	`851`	`return fmt.Errorf("failed to create directory %q. err: %s", outputDir, err.Error())`
`852`	`852`	`}`
`@@ -868,7 +868,7 @@ func (d *DaVinciGenerator) writeAsset(flowAsset flowAssetData) error {`
`868`	`868`	`return fmt.Errorf("Cannot marshal asset data: %s", err)`
`869`	`869`	`}`
`870`	`870`
`871`		`- err = os.WriteFile(fmt.Sprintf("%s/%s", d.outputPath, flowAsset.path), fileData, 0644)`
	`871`	`+ err = os.WriteFile(fmt.Sprintf("%s/%s", d.outputPath, flowAsset.path), fileData, 0600)`
`872`	`872`	`if err != nil {`
`873`	`873`	`return fmt.Errorf("Cannot write asset file %s: %s", flowAsset.path, err)`
`874`	`874`	`}`