added default gate error handler; fixed some undef warnings

Author: kelatidd

src/Classes/Api/PaynetApi.php

@@ -73,8 +73,8 @@ private function execute(string $action, array $data): array {
 		foreach ($result as $k => $v)
 			$result[$k] = rtrim($v);
 
-    if (preg_match('/error/', $result['type']))
-      throw new PayneteasyException("Card processing reports error: {$result['error-message']}", [ 'response' => $response ]);
+		if ($result['type'] == 'validation-error')
+			throw new PayneteasyException("Card processing reports error: {$result['error-message']}", [ 'response' => $response ]);
 
 		return $result;
 	}

wc-payneteasy.php

@@ -69,7 +69,7 @@ private function init_payment_settings(): array {
 
 				if (property_exists($this, $k))
 					$this->$k = $s[$k];
-			}		
+			}
 
 			$s['is_direct'] = $s['payment_method'] == 'direct';
 			$s['gate'] = $s['sandbox'] ? $s['sandbox_url'] : $s['live_url'];
@@ -96,7 +96,8 @@ public function process_payment($order_id): ?array {
 
 				$sale = $this->make_sale();
 
-				$this->order->update_status('pending', __('Payment link generated:', 'wc-payneteasy').$sale['redirect-url'] ?: '');
+				if (isset($sale['redirect-url']))
+					$this->order->update_status('pending', __('Payment link generated:', 'wc-payneteasy').$sale['redirect-url']);
 
 				return $this->api->is_direct()
 					? [ 'result' => 'success', 'redirect' => home_url("?wc-api={$this->id}_return&orderId=$order_id") ]
@@ -110,6 +111,7 @@ public function process_payment($order_id): ?array {
 
 		private function make_sale(): array {
 			[ $order_id, $email, $total ] = [ $this->order->get_id(), $this->order->get_billing_email(), $this->order->get_total() ];
+
 			$return_url = home_url("?wc-api={$this->id}_return&orderId=$order_id");
 
 			$response = $this->api->sale([
@@ -150,7 +152,7 @@ private static function form_cell(?array $cell, string $class): string {
 				? "<div class='form-row-$class'><label>{$cell[0]} <span class='required'>*</span></label>"
 					."<input id='{$cell[1]}' name='{$cell[1]}' type='text'"
 					.($cell[2] ? " autocomplete='{$cell[2]}'" : '')
-					." {$cell[3]}></div>"
+					.' '.($cell[3] ?? '').'></div>'
 				: '';
 		}
 
@@ -202,12 +204,13 @@ public function return_handler(): void {
 				$this->set_order($order_id);
 				$this->change_payment_status($payment_status = $this->get_payment_status($three_d_html));
 
+				WC()->cart->empty_cart(); # иначе продолжает слать всё тот же ордер_ид, и гейт отдаёт один и тот же запрос
+
 				switch ($payment_status) {
 					case 'sale/processing':
 						echo $three_d_html;
 						die();
 					case 'sale/approved':
-						WC()->cart->empty_cart();
 						echo '<div style="width: 100%; text-align: center"><div><h1>Your payment was approved. Thank you.</h1></div><div><a href="'.get_site_url().'">Return homepage</a></div></div>';
 						die();
 					case 'sale/error':
@@ -216,6 +219,9 @@ public function return_handler(): void {
 					case 'sale/declined':
 						echo '<div style="width: 100%; text-align: center"><div><h1>Your payment was declined. Could you try again.</h1></div><div><a href="'.get_site_url().'">Return homepage</a></div></div>';
 						die();
+					default:
+						echo '<div style="width: 100%; text-align: center"><div><h1>Transaction is declined but something went wrong, please inform your account manager, final status</h1></div><div><a href="'.get_site_url().'">Return homepage</a></div></div>';
+						die();
 				}
 			}
 			catch (\Exception | PayneteasyException $e)
@@ -390,7 +396,7 @@ private function get_payment_status(&$three_d_html = null): string {
 
 			$response = $this->api->status([ 'client_orderid' => $this->order->get_id(), 'orderid' => $paynet_order_id ]);
 
-			$three_d_html = $response['html'];
+			$three_d_html = $response['html'] ?? null;
 			return "{$response['transaction-type']}/{$response['status']}";
 		}
 	}