bump coverage

Author: ySnoopyDogy

requests/validate_body_test.go

@@ -1578,6 +1578,45 @@ paths:
 	assert.Len(t, errors, 0)
 }
 
+func TestValidateRequestBody_XMLMarshalError(t *testing.T) {
+	spec := []byte(`
+openapi: 3.1.0
+info:
+  title: Test Spec
+  version: 1.0.0
+paths:
+  /test:
+    post:
+      requestBody:
+        required: true
+        content:
+          application/xml:
+            schema:
+              type: object
+              properties:
+                bad_number:
+                  type: number
+      responses:
+        '200':
+          description: Success
+`)
+
+	doc, _ := libopenapi.NewDocument([]byte(spec))
+
+	m, _ := doc.BuildV3Model()
+	v := NewRequestBodyValidator(&m.Model, config.WithXmlBodyValidation())
+
+	request, _ := http.NewRequest(http.MethodPost, "https://things.com/test",
+		bytes.NewBuffer([]byte("<bad_number>NaN</bad_number>")))
+	request.Header.Set("Content-Type", "application/xml")
+
+	valid, errors := v.ValidateRequestBody(request)
+
+	assert.False(t, valid)
+	assert.Len(t, errors, 1)
+	assert.Equal(t, errors[0].Message, "xml example is malformed")
+}
+
 func TestValidateBody_XmlRequest(t *testing.T) {
 	spec := `openapi: 3.1.0
 paths:

responses/validate_body_test.go

@@ -44,7 +44,7 @@ func newvalidateResponseTestBed(
 		t.Fatalf("failed to build v3 model: %v", err)
 	}
 
-	tb := validateResponseTestBed{responseBodyValidator: NewResponseBodyValidator(&m.Model)}
+	tb := validateResponseTestBed{responseBodyValidator: NewResponseBodyValidator(&m.Model, config.WithXmlBodyValidation())}
 	tb.httpTestServer = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if tb.responseHandlerFunc != nil {
 			tb.responseHandlerFunc(w, r)
@@ -1281,6 +1281,85 @@ components:
 			strings.Contains(errors[0].Reason, "not found"),
 		"Expected error about circular reference or JSON pointer not found, got: %s", errors[0].Reason)
 }
+func TestValidateResponseBody_XMLMarshalError(t *testing.T) {
+	tb := newvalidateResponseTestBed(
+		t,
+		[]byte(`
+openapi: 3.1.0
+info:
+  title: Test Spec
+  version: 1.0.0
+paths:
+  /test:
+    get:
+      responses:
+        '200':
+          description: Success
+          content:
+            application/xml:
+              schema:
+                type: object
+                properties:
+                  bad_number:
+                    type: number
+`,
+		),
+	)
+
+	req, res := tb.makeRequestWithReponse(
+		t,
+		http.MethodGet,
+		"/test",
+		func(w http.ResponseWriter, r *http.Request) {
+			w.Header().Set(helpers.ContentTypeHeader, "application/xml")
+			w.WriteHeader(http.StatusOK)
+			_, _ = w.Write([]byte("<bad_number>NaN</bad_number>"))
+		},
+	)
+
+	valid, errors := tb.responseBodyValidator.ValidateResponseBody(req, res)
+
+	assert.False(t, valid)
+	assert.Len(t, errors, 1)
+	assert.Equal(t, errors[0].Message, "xml example is malformed")
+}
+
+func TestValidateResponseBody_NilSchema(t *testing.T) {
+	tb := newvalidateResponseTestBed(
+		t,
+		[]byte(`
+openapi: 3.1.0
+info:
+  title: Test Spec
+  version: 1.0.0
+paths:
+  /test:
+    get:
+      responses:
+        '200':
+          description: Success
+          content:
+            application/json: {}
+`,
+		),
+	)
+
+	req, res := tb.makeRequestWithReponse(
+		t,
+		http.MethodGet,
+		"/test",
+		func(w http.ResponseWriter, r *http.Request) {
+			w.Header().Set(helpers.ContentTypeHeader, helpers.JSONContentType)
+			w.WriteHeader(http.StatusOK)
+			_, _ = w.Write(nil)
+		},
+	)
+
+	valid, errors := tb.responseBodyValidator.ValidateResponseBody(req, res)
+
+	assert.True(t, valid)
+	assert.Len(t, errors, 0)
+}
 
 func TestValidateBody_CheckHeader(t *testing.T) {
 	spec := `openapi: "3.0.0"

schema_validation/validate_xml_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/pb33f/libopenapi"
 	"github.com/pb33f/libopenapi-validator/helpers"
 	"github.com/pb33f/libopenapi/datamodel/high/base"
+	"github.com/pb33f/libopenapi/orderedmap"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -1232,3 +1233,21 @@ func TestApplyXMLTransformations_IncorrectSchema(t *testing.T) {
 	assert.Equal(t, "got string, want boolean", err[0].SchemaValidationErrors[0].Reason)
 	assert.Equal(t, "schema does not pass validation", err[0].Message)
 }
+func TestApplyXMLTransformations_NilPropSchema(t *testing.T) {
+	schema := &base.Schema{
+		Properties: orderedmap.New[string, *base.SchemaProxy](),
+	}
+
+	emptyProxy := &base.SchemaProxy{}
+	schema.Properties.Set("broken_ref_prop", emptyProxy)
+
+	data := map[string]any{
+		"broken_ref_prop": "some_value",
+	}
+	xmlNsMap := make(map[string]string)
+
+	result, errs := applyXMLTransformations(data, schema, &xmlNsMap)
+
+	assert.Len(t, errs, 0)
+	assert.NotNil(t, result)
+}