fix: validate errors within head response object

Author: saisatishkarra

helpers/operation_utilities.go

@@ -7,7 +7,7 @@ import (
 	"mime"
 	"net/http"
 
-	v3 "github.com/pb33f/libopenapi/datamodel/high/v3"
+	"github.com/pb33f/libopenapi/datamodel/high/v3"
 )
 
 // ExtractOperation extracts the operation from the path item based on the request method. If there is no

helpers/operation_utilities_test.go

@@ -8,7 +8,7 @@ import (
 	"net/http"
 	"testing"
 
-	v3 "github.com/pb33f/libopenapi/datamodel/high/v3"
+	"github.com/pb33f/libopenapi/datamodel/high/v3"
 	"github.com/stretchr/testify/require"
 )
 

responses/validate_body.go

@@ -138,6 +138,7 @@ func (v *responseBodyValidator) checkResponseSchema(
 		// extract schema from media type
 		if mediaType.Schema != nil {
 			schema := mediaType.Schema.Schema()
+
 			// Validate response schema
 			valid, vErrs := ValidateResponseSchema(&ValidateResponseSchemaInput{
 				Request:  request,

responses/validate_response.go

@@ -156,14 +156,14 @@ func ValidateResponseSchema(input *ValidateResponseSchemaInput) (bool, []*errors
 	request := input.Request
 	response := input.Response
 	schema := input.Schema
+	
 
 	if response == nil || response.Body == http.NoBody {
 
 		// skip response body validation for head request after processing schema
-		if request != nil && request.Method == http.MethodHead {
-			return true, validationErrors
+		if response != nil && request != nil && request.Method == http.MethodHead {
+			return len(validationErrors) == 0, validationErrors
 		}
-
 		// cannot decode the response body, so it's not valid
 		violation := &errors.SchemaValidationFailure{
 			Reason:          "response is empty",
@@ -215,6 +215,7 @@ func ValidateResponseSchema(input *ValidateResponseSchemaInput) (bool, []*errors
 
 	var decodedObj interface{}
 
+	
 	if len(responseBody) > 0 {
 		// Per RFC7231, a response to a HEAD request MUST NOT include a message body.
 		if request != nil && request.Method == http.MethodHead {

responses/validate_response_test.go

@@ -295,7 +295,7 @@ func TestValidateResponseSchema_ResponseMissing(t *testing.T) {
 	schema := parseSchemaFromSpec(t, `type: object
 properties:
   name:
-	type: string`, 3.1)
+    type: string`, 3.1)
 
 	// Response body missing (NoBody) for a non-HEAD request should error
 	valid, errs := ValidateResponseSchema(&ValidateResponseSchemaInput{