bump error coverage

Author: ySnoopyDogy

requests/validate_body.go

@@ -111,8 +111,15 @@ func (v *requestBodyValidator) ValidateRequestBodyWithPathItem(request *http.Req
 				return false, prevalidationErrors
 			}
 
-			// If prevalidationErrors has no items, jsonBody is a valid JSON structure
-			transformedBytes, _ := json.Marshal(jsonBody)
+			transformedBytes, err := json.Marshal(jsonBody)
+			if err != nil {
+				switch {
+				case isXml:
+					return false, []*errors.ValidationError{errors.InvalidXMLParsing(err.Error(), stringedBody)}
+				case isUrlEncoded:
+					return false, []*errors.ValidationError{errors.InvalidURLEncodedParsing(err.Error(), stringedBody)}
+				}
+			}
 
 			request.Body = io.NopCloser(bytes.NewBuffer(transformedBytes))
 		}

requests/validate_body_test.go

@@ -1617,6 +1617,45 @@ paths:
 	assert.Equal(t, errors[0].Message, "xml example is malformed")
 }
 
+func TestValidateRequestBody_URLEncodedMarshalError(t *testing.T) {
+	spec := []byte(`
+openapi: 3.1.0
+info:
+  title: Test Spec
+  version: 1.0.0
+paths:
+  /test:
+    post:
+      requestBody:
+        required: true
+        content:
+          application/x-www-form-urlencoded:
+            schema:
+              type: object
+              properties:
+                bad_number:
+                  type: number
+      responses:
+        '200':
+          description: Success
+`)
+
+	doc, _ := libopenapi.NewDocument([]byte(spec))
+
+	m, _ := doc.BuildV3Model()
+	v := NewRequestBodyValidator(&m.Model, config.WithURLEncodedBodyValidation())
+
+	request, _ := http.NewRequest(http.MethodPost, "https://things.com/test",
+		bytes.NewBuffer([]byte("bad_number=NaN")))
+	request.Header.Set("Content-Type", helpers.URLEncodedContentType)
+
+	valid, errors := v.ValidateRequestBody(request)
+
+	assert.False(t, valid)
+	assert.Len(t, errors, 1)
+	assert.Equal(t, errors[0].Message, "Unable to parse form-urlencoded body")
+}
+
 func TestValidateBody_URLEncodedRequest(t *testing.T) {
 	spec := `openapi: 3.1.0
 paths:

responses/validate_body.go

@@ -176,8 +176,15 @@ func (v *responseBodyValidator) checkResponseSchema(
 				return prevalidationErrors
 			}
 
-			// If prevalidationErrors has no items, jsonBody is a valid JSON structure
-			transformedBytes, _ := json.Marshal(jsonBody)
+			transformedBytes, err := json.Marshal(jsonBody)
+			if err != nil {
+				switch {
+				case isXml:
+					return []*errors.ValidationError{errors.InvalidXMLParsing(err.Error(), stringedBody)}
+				case isUrlEncoded:
+					return []*errors.ValidationError{errors.InvalidURLEncodedParsing(err.Error(), stringedBody)}
+				}
+			}
 
 			response.Body = io.NopCloser(bytes.NewBuffer(transformedBytes))
 		}

responses/validate_body_test.go

@@ -44,7 +44,7 @@ func newvalidateResponseTestBed(
 		t.Fatalf("failed to build v3 model: %v", err)
 	}
 
-	tb := validateResponseTestBed{responseBodyValidator: NewResponseBodyValidator(&m.Model, config.WithXmlBodyValidation())}
+	tb := validateResponseTestBed{responseBodyValidator: NewResponseBodyValidator(&m.Model, config.WithXmlBodyValidation(), config.WithURLEncodedBodyValidation())}
 	tb.httpTestServer = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if tb.responseHandlerFunc != nil {
 			tb.responseHandlerFunc(w, r)
@@ -1325,6 +1325,49 @@ paths:
 	assert.Equal(t, errors[0].Message, "xml example is malformed")
 }
 
+func TestValidateResponseBody_URLEncodedMarshalError(t *testing.T) {
+	tb := newvalidateResponseTestBed(
+		t,
+		[]byte(`
+openapi: 3.1.0
+info:
+  title: Test Spec
+  version: 1.0.0
+paths:
+  /test:
+    get:
+      responses:
+        '200':
+          description: Success
+          content:
+            application/x-www-form-urlencoded:
+              schema:
+                type: object
+                properties:
+                  bad_number:
+                    type: number
+`,
+		),
+	)
+
+	req, res := tb.makeRequestWithReponse(
+		t,
+		http.MethodGet,
+		"/test",
+		func(w http.ResponseWriter, r *http.Request) {
+			w.Header().Set(helpers.ContentTypeHeader, helpers.URLEncodedContentType)
+			w.WriteHeader(http.StatusOK)
+			_, _ = w.Write([]byte("bad_number=NaN"))
+		},
+	)
+
+	valid, errors := tb.responseBodyValidator.ValidateResponseBody(req, res)
+
+	assert.False(t, valid)
+	assert.Len(t, errors, 1)
+	assert.Equal(t, errors[0].Message, "Unable to parse form-urlencoded body")
+}
+
 func TestValidateResponseBody_NilSchema(t *testing.T) {
 	tb := newvalidateResponseTestBed(
 		t,