fix: catch invalid enums

Author: jthomperoo

QueryKit.IntegrationTests/Tests/DatabaseSortingTests.cs

@@ -3,6 +3,7 @@ namespace QueryKit.IntegrationTests.Tests;
 using Bogus;
 using FluentAssertions;
 using Microsoft.EntityFrameworkCore;
+using QueryKit.Exceptions;
 using SharedTestingHelper.Fakes;
 using WebApiTestProject.Entities;
 
@@ -165,7 +166,7 @@ public async Task a_prop_with_hasconversion_must_match_that_configuration()
         var act = () => appliedQueryable.ToListAsync();
 
         // Assert
-        await act.Should().ThrowAsync<InvalidOperationException>();
+        await act.Should().ThrowAsync<ParsingException>();
     }
 
     [Fact]
@@ -242,4 +243,4 @@ public async Task can_sort_items_with_null_value_property()
         people[2].Id.Should().Be(fakePersonFour.Id);
         people[3].Id.Should().Be(fakePersonThree.Id);
     }
-}
+}

QueryKit.UnitTests/FilterParserTests.cs

@@ -799,5 +799,14 @@ public void primitive_collection_does_not_have_case_insensitive()
         filterExpression.ToString().Should()
             .Be(""""x => x.Tags.Any(z => (z.ToLower() != "winner".ToLower()))"""");
     }
+    
+    [Fact]
+    public void can_throw_exception_when_invalid_enum_value()
+    {
+        var input = $"""BirthMonth == invalid""";
+        var act = () => FilterParser.ParseFilter<TestingPerson>(input);
+        act.Should().Throw<ParsingException>()
+        .WithMessage("There was a parsing failure, likely due to an invalid comparison or logical operator. You may also be missing double quotes surrounding a string or guid.");
+    }
 }
 

QueryKit/FilterParser.cs

@@ -31,6 +31,9 @@ public static Expression<Func<T, bool>> ParseFilter<T>(string input, IQueryKitCo
         {
             expr = ExprParser<T>(parameter, config).End().Parse(input);
         }
+        catch (InvalidOperationException e) {
+            throw new ParsingException(e);
+        }
         catch (ParseException e)
         {
             throw new ParsingException(e);
@@ -314,7 +317,12 @@ private static Expression CreateRightExprFromType(Type leftExprType, string righ
                 return Expression.Constant(null, rawType);
             }
 
-            var enumValue = Enum.Parse(enumType, right);
+            var parsed = Enum.TryParse(enumType, right, out var enumValue);
+            if (!parsed) 
+            {
+                throw new InvalidOperationException($"Unsupported value '{right}' for type '{targetType.Name}'");
+            }
+            
             var constant = Expression.Constant(enumValue, enumType);
 
             if (rawType == enumType) return constant;