Skip to content

Commit ca97c4e

Browse files
chore: Apply final polish and gold standard improvements from audit
1 parent 51a568e commit ca97c4e

13 files changed

Lines changed: 28 additions & 20 deletions

File tree

.devcontainer/boot-check.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ else
99
while IFS='=' read -r key value; do
1010
# Skip empty lines and comments
1111
if [[ -n "$key" && ! "$key" =~ ^# ]]; then
12-
# Trim leading/trailing whitespace from key and value
13-
key=$(echo "$key" | xargs)
14-
value=$(echo "$value" | xargs)
12+
# Trim leading/trailing whitespace
13+
key="${key#"${key%%[![:space:]]*}"}"
14+
key="${key%"${key##*[![:space:]]}"}"
15+
value="${value#"${value%%[![:space:]]*}"}"
16+
value="${value%"${value##*[![:space:]]}"}"
1517
export "$key=$value"
1618
fi
1719
done < ".env"

.devcontainer/devcontainer.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@
2121
"GitHub.github-vscode-theme",
2222
"bierner.markdown-mermaid",
2323
"mechatroner.rainbow-csv",
24-
"ms-vscode.makefile-tools"
24+
"ms-vscode.makefile-tools",
25+
"ms-azuretools.vscode-containers",
26+
"ms-azuretools.vscode-docker",
27+
"github.vscode-github-actions",
28+
"github.vscode-pull-request-github"
2529
],
2630
"settings": {
2731
"workbench.startupEditor": "none"

.env.example

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,4 @@ SSH_PUBLIC_KEY=
1010
# Get your key at: https://aistudio.google.com/app/apikey
1111
GEMINI_API_KEY=
1212

13-
1413
# Add project specific secrets below

.github/workflows/devcontainer-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: Devcontainer Build Validation
22

33
on:
44
push:
5-
branches: [ main, booting ]
5+
branches: [main, booting]
66
pull_request:
7-
branches: [ main ]
7+
branches: [main]
88

99
jobs:
1010
build-root:

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ It is critical to distinguish between the two development environments in this r
4141
### Modifying the Generator (`install.sh`)
4242

4343
- Changes to `install.sh` should be extremely rare. It must remain lightweight.
44-
- Ensure that the tarball extraction logic (`tar -xz --strip-components=2 "*/templates/"`) remains robust. It relies on GitHub's tarball structure.
44+
- Ensure that the tarball extraction logic (utilizing `--wildcards` for the `/templates` directory) remains robust. It relies on GitHub's tarball structure.
4545

4646
## 📝 Contribution & Maintenance Rules
4747

install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ fi
2525
mkdir -p docs/decisions
2626

2727
# Make scripts executable
28-
chmod +x .devcontainer/boot-check.sh scripts/setup-env.sh scripts/setup-gemini.sh scripts/start-container.sh
28+
chmod +x .devcontainer/boot-check.sh scripts/setup-env.sh scripts/setup-gemini.sh scripts/start-container.sh scripts/troubleshooting.sh
2929
chmod +x .githooks/*
3030

3131
echo "✅ Bootstrap complete. Open in VS Code or Antigravity to start the Devcontainer."

scripts/setup-env.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ if [ -n "$GEMINI_API_KEY" ]; then
7272
update_env "GEMINI_API_KEY" "$GEMINI_API_KEY"
7373
fi
7474

75-
76-
7775
# Update the LICENSE file if it exists
7876
if [ -f "LICENSE" ] && [ -n "$GIT_NAME" ]; then
7977
CURRENT_YEAR=$(date +"%Y")

templates/.env.example

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,4 @@ SSH_PUBLIC_KEY=
1010
# Get your key at: https://aistudio.google.com/app/apikey
1111
GEMINI_API_KEY=
1212

13-
1413
# Add project specific secrets below

templates/.github/CODEOWNERS

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
# Default owners for everything
1+
# Default owners for everything. Note: team slugs like @core-maintainers
2+
# are placeholders and must be updated to match teams in your GitHub organization.
23
* @core-maintainers
34

45
# Architecture decisions require Tech Lead review

templates/AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ When adding or modifying automation scripts for the devcontainer, you must adher
5555

5656
## 🤖 Token Optimization & CLI Usage
5757

58-
- **GitHub CLI:** The `gh` command is available in this container. If a `GITHUB_TOKEN` is provided in `.env`, the host's CLI will be authenticated and `gh auth setup-git` will automatically configure it as your Git credential helper. This enables seamless HTTPS Git operations in the environment. See [.env.example](.env.example) for required `GITHUB_TOKEN` scopes.
58+
- **GitHub CLI:** The `gh` command is available in this container. Use `gh auth login` to authenticate. This enables seamless GitHub operations and can configure Git as your credential helper.
5959
- **Offload Structured Edge-Tasks:** To preserve your context window (tokens) for complex logic, use the Gemini CLI (`@google/gemini-cli`) installed in this container for well-structured tasks.
6060
- **Usage:** Run `gemini` in the terminal to start an interactive session, or `gemini -p "<prompt>"` for one-shot tasks.
6161
- **Examples:** Ask the CLI to review code, analyze architecture, or investigate issues—this keeps your IDE context window focused on the primary task.

0 commit comments

Comments
 (0)