Fix test compatibility with Bazel versions before 8

Author: kiberbunozes-ceo

tests/test_defs.bzl

@@ -78,3 +78,6 @@ helm_package_regex_test = rule(
     },
     test = True,
 )
+
+def label_to_str(label):
+    return str(Label(label))

tests/with_image_deps_img/BUILD.bazel

@@ -3,7 +3,7 @@ load("@rules_img//img:image.bzl", "image_manifest")
 load("@rules_img//img:layer.bzl", "image_layer")
 load("@rules_img//img:push.bzl", "image_push")
 load("//helm:defs.bzl", "helm_chart", "helm_lint_test", "helm_template_test")
-load("//tests:test_defs.bzl", "helm_package_regex_test")
+load("//tests:test_defs.bzl", "helm_package_regex_test", "label_to_str")
 
 exports_files(["Chart.lock"])
 
@@ -23,6 +23,14 @@ helm_chart(
         ":image_e.push",
         "@rules_helm_test_img_container_base",
     ],
+    substitutions = {
+        # This goofy workaround is needed because Bazel 8 has '~' characters in
+        # the label string, while newer versions have '+'. Relying on the fact
+        # that the substitutions are handled before image stamps, we can do a
+        # double replacement, and thus avoid hardcoding either character into
+        # the values file ensuring compatibility with both versions
+        "base_container_label": label_to_str("@rules_helm_test_img_container_base//:image"),
+    },
     target_compatible_with = EXCLUDE_WINDOWS,
 )
 

tests/with_image_deps_img/values.yaml

@@ -24,7 +24,7 @@ bazel_produced_images:
   image_pull:
     url: "{@+helm_test+rules_helm_test_img_container_base//:image}"
   image_pull_tag:
-    url: "{@+helm_test+rules_helm_test_img_container_base//:image.repository}:{@+helm_test+rules_helm_test_img_container_base//:image.tag}"
+    url: "{@{base_container_label}.repository}:{@{base_container_label}.tag}"
 
 imagePullSecrets: []
 nameOverride: ""