Use rewrite_rules_array filter for better performance

Instead of calling add_rewrite_rule() on every init hook, use the
rewrite_rules_array filter which only fires during flush operations.
This is more efficient as rules are cached in the database.

Author: pfefferle

includes/class-nodeinfo.php

@@ -98,8 +98,8 @@ public function register_hooks() {
 		\add_filter( 'webfinger_post_data', array( Controller_Nodeinfo::class, 'jrd' ), 10, 3 );
 		\add_filter( 'host_meta', array( Controller_Nodeinfo::class, 'jrd' ) );
 
-		// Add rewrite rules for well-known endpoints.
-		\add_action( 'init', array( $this, 'add_rewrite_rules' ), 1 );
+		// Add rewrite rules for well-known endpoints (only during flush).
+		\add_filter( 'rewrite_rules_array', array( $this, 'add_rewrite_rules' ) );
 
 		// Register deprecated filter handlers.
 		\add_filter( 'nodeinfo_discovery', array( $this, 'deprecated_wellknown_nodeinfo_data' ), 99 );
@@ -148,25 +148,27 @@ public function register_routes() {
 
 	/**
 	 * Add rewrite rules for well-known endpoints.
+	 *
+	 * @param array $rules The existing rewrite rules.
+	 * @return array The modified rewrite rules.
 	 */
-	public function add_rewrite_rules() {
-		\add_rewrite_rule( '^.well-known/nodeinfo', 'index.php?rest_route=/nodeinfo/discovery', 'top' );
-		\add_rewrite_rule( '^.well-known/x-nodeinfo2', 'index.php?rest_route=/nodeinfo2/1.0', 'top' );
+	public function add_rewrite_rules( $rules ) {
+		$new_rules = array(
+			'^.well-known/nodeinfo'    => 'index.php?rest_route=/nodeinfo/discovery',
+			'^.well-known/x-nodeinfo2' => 'index.php?rest_route=/nodeinfo2/1.0',
+		);
+
+		return \array_merge( $new_rules, $rules );
 	}
 
 	/**
 	 * Handle plugin activation.
 	 *
-	 * Initializes the plugin and flushes rewrite rules.
-	 *
-	 * Note: We call init() to register all hooks. However, during activation
-	 * the 'init' hook may have already fired, so we also call add_rewrite_rules()
-	 * directly to ensure rules are registered.
+	 * Initializes the plugin and flushes rewrite rules. The rewrite_rules_array
+	 * filter will add our rules during the flush.
 	 */
 	public static function activate() {
-		$instance = self::get_instance();
-		$instance->init();
-		$instance->add_rewrite_rules();
+		self::get_instance()->init();
 		\flush_rewrite_rules();
 	}
 

tests/phpunit/tests/class-test-nodeinfo.php

@@ -81,28 +81,16 @@ public function test_integrations_register_versions() {
 	 * @covers ::add_rewrite_rules
 	 */
 	public function test_rewrite_rules_added() {
-		global $wp_rewrite;
-
-		// Save original permalink structure.
-		$original_structure = $wp_rewrite->permalink_structure;
-
-		// Enable permalinks for testing.
-		$wp_rewrite->set_permalink_structure( '/%postname%/' );
-
-		// Add rewrite rules.
-		\Nodeinfo\Nodeinfo::get_instance()->add_rewrite_rules();
-		$wp_rewrite->flush_rules();
+		$instance = \Nodeinfo\Nodeinfo::get_instance();
 
-		$rules = $wp_rewrite->wp_rewrite_rules();
+		// Test the filter directly.
+		$rules = $instance->add_rewrite_rules( array() );
 
-		// Ensure rules is an array.
 		$this->assertIsArray( $rules );
 		$this->assertArrayHasKey( '^.well-known/nodeinfo', $rules );
 		$this->assertArrayHasKey( '^.well-known/x-nodeinfo2', $rules );
-
-		// Restore original permalink structure.
-		$wp_rewrite->set_permalink_structure( $original_structure );
-		$wp_rewrite->flush_rules();
+		$this->assertEquals( 'index.php?rest_route=/nodeinfo/discovery', $rules['^.well-known/nodeinfo'] );
+		$this->assertEquals( 'index.php?rest_route=/nodeinfo2/1.0', $rules['^.well-known/x-nodeinfo2'] );
 	}
 
 	/**
@@ -175,30 +163,16 @@ public function test_init_guard_prevents_double_initialization() {
 	}
 
 	/**
-	 * Test activate() method registers rewrite rules.
+	 * Test activate() method initializes plugin and flushes rewrite rules.
 	 *
 	 * @covers ::activate
 	 */
-	public function test_activate_registers_rewrite_rules() {
-		global $wp_rewrite;
-
-		// Save original permalink structure.
-		$original_structure = $wp_rewrite->permalink_structure;
-
-		// Enable permalinks for testing.
-		$wp_rewrite->set_permalink_structure( '/%postname%/' );
-
-		// Call activate.
+	public function test_activate_initializes_and_flushes() {
+		// Verify activate() runs without errors and initializes the plugin.
 		\Nodeinfo\Nodeinfo::activate();
 
-		$rules = $wp_rewrite->wp_rewrite_rules();
-
-		$this->assertIsArray( $rules );
-		$this->assertArrayHasKey( '^.well-known/nodeinfo', $rules );
-
-		// Restore original permalink structure.
-		$wp_rewrite->set_permalink_structure( $original_structure );
-		$wp_rewrite->flush_rules();
+		// Verify the rewrite_rules_array filter is registered.
+		$this->assertNotFalse( has_filter( 'rewrite_rules_array' ) );
 	}
 
 	/**