Fix issues from code review

- Add backslash to @return WP_REST_Response types
- Add fields parameter to get_users for performance
- Add version 2.2 to test coverage

Author: pfefferle

includes/controller/class-nodeinfo.php

@@ -83,7 +83,7 @@ protected function get_versions() {
 	/**
 	 * Retrieves the discovery document.
 	 *
-	 * @return WP_REST_Response The response object.
+	 * @return \WP_REST_Response The response object.
 	 */
 	public function get_discovery() {
 		$links = array();
@@ -114,7 +114,7 @@ public function get_discovery() {
 	 * Retrieves NodeInfo for a specific version.
 	 *
 	 * @param \WP_REST_Request $request The request object.
-	 * @return WP_REST_Response The response object.
+	 * @return \WP_REST_Response The response object.
 	 */
 	public function get_item( $request ) {
 		$version = $request->get_param( 'version' );

includes/controller/class-nodeinfo2.php

@@ -63,6 +63,7 @@ public function get_item( $request ) {
 		$users = \get_users(
 			array(
 				'capability__in' => array( 'publish_posts' ),
+				'fields'         => 'ID',
 			)
 		);
 

tests/phpunit/tests/class-test-nodeinfo-endpoint.php

@@ -92,7 +92,7 @@ public function test_discovery_contains_all_versions() {
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$versions = array( '1.0', '1.1', '2.0', '2.1' );
+		$versions = array( '1.0', '1.1', '2.0', '2.1', '2.2' );
 		$links    = $data['links'];
 
 		foreach ( $versions as $version ) {