addressing static code issue

Author: tsivaprasad

server/internal/orchestrator/swarm/rag_service_user_role.go

@@ -203,20 +203,11 @@ func (r *RAGServiceUserRole) connectToColocatedPrimary(ctx context.Context, rc *
 		return nil, err
 	}
 
-	db, err := dbSvc.GetDatabase(ctx, r.DatabaseID)
+	primaryInstanceID, err := r.resolveColocatedPrimary(ctx, dbSvc, logger)
 	if err != nil {
-		if errors.Is(err, database.ErrDatabaseNotFound) {
-			return nil, fmt.Errorf("database not found: %w", err)
-		}
-		return nil, fmt.Errorf("failed to get database: %w", err)
-	}
-	if len(db.Instances) == 0 {
-		return nil, fmt.Errorf("database has no instances")
+		return nil, err
 	}
 
-	candidates := r.colocatedInstances(db.Instances, logger)
-	primaryInstanceID := r.findPrimaryAmong(ctx, dbSvc, candidates, logger)
-
 	connInfo, err := dbSvc.GetInstanceConnectionInfo(ctx, r.DatabaseID, primaryInstanceID)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get instance connection info: %w", err)
@@ -243,6 +234,23 @@ func (r *RAGServiceUserRole) connectToColocatedPrimary(ctx context.Context, rc *
 	return conn, nil
 }
 
+// resolveColocatedPrimary fetches the database, selects co-located instances,
+// and returns the primary instance ID via Patroni.
+func (r *RAGServiceUserRole) resolveColocatedPrimary(ctx context.Context, dbSvc *database.Service, logger zerolog.Logger) (string, error) {
+	db, err := dbSvc.GetDatabase(ctx, r.DatabaseID)
+	if err != nil {
+		if errors.Is(err, database.ErrDatabaseNotFound) {
+			return "", fmt.Errorf("database not found: %w", err)
+		}
+		return "", fmt.Errorf("failed to get database: %w", err)
+	}
+	if len(db.Instances) == 0 {
+		return "", fmt.Errorf("database has no instances")
+	}
+	candidates := r.colocatedInstances(db.Instances, logger)
+	return r.findPrimaryAmong(ctx, dbSvc, candidates, logger), nil
+}
+
 // colocatedInstances returns the subset of instances that share r.HostID.
 // Falls back to all instances if none are co-located.
 func (r *RAGServiceUserRole) colocatedInstances(all []*database.Instance, logger zerolog.Logger) []*database.Instance {