Fixed SparseVector constructor for SciPy sparse matrices - fixes #127

Author: ankane

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.4.1 (unreleased)
+
+- Fixed `SparseVector` constructor for SciPy sparse matrices
+
 ## 0.4.0 (2025-03-15)
 
 - Added top-level `pgvector` package

pgvector/sparsevec.py

@@ -85,7 +85,7 @@ def _from_sparse(self, value):
 
         if hasattr(value, 'coords'):
             # scipy 1.13+
-            self._indices = value.coords[0].tolist()
+            self._indices = value.coords[-1].tolist()
         else:
             self._indices = value.col.tolist()
         self._values = value.data.tolist()

tests/test_sparse_vector.py

@@ -1,7 +1,7 @@
 import numpy as np
 from pgvector import SparseVector
 import pytest
-from scipy.sparse import coo_array
+from scipy.sparse import coo_array, csr_array, csr_matrix
 from struct import pack
 
 
@@ -49,6 +49,18 @@ def test_dok_array(self):
         assert vec.to_list() == [1, 0, 2, 0, 3, 0]
         assert vec.indices() == [0, 2, 4]
 
+    def test_csr_array(self):
+        arr = csr_array(np.array([1, 0, 2, 0, 3, 0]))
+        vec = SparseVector(arr)
+        assert vec.to_list() == [1, 0, 2, 0, 3, 0]
+        assert vec.indices() == [0, 2, 4]
+
+    def test_csr_matrix(self):
+        mat = csr_matrix(np.array([1, 0, 2, 0, 3, 0]))
+        vec = SparseVector(mat)
+        assert vec.to_list() == [1, 0, 2, 0, 3, 0]
+        assert vec.indices() == [0, 2, 4]
+
     def test_repr(self):
         assert repr(SparseVector([1, 0, 2, 0, 3, 0])) == 'SparseVector({0: 1.0, 2: 2.0, 4: 3.0}, 6)'
         assert str(SparseVector([1, 0, 2, 0, 3, 0])) == 'SparseVector({0: 1.0, 2: 2.0, 4: 3.0}, 6)'