Skip to content

Commit 8d71fee

Browse files
v1.2.2 (#11)
* Added test duplicating issue in #10. * Correct linting errors. * Resolve error with downloading thumbnails. * 1.2.2
1 parent 763150b commit 8d71fee

11 files changed

Lines changed: 32 additions & 24 deletions

File tree

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "phaxio-official",
3-
"version": "1.2.1",
3+
"version": "1.2.2",
44
"description": "The official Node.JS library for Phaxio API v2.1.0. https://phaxio.com",
55
"main": "index.js",
66
"scripts": {

src/account/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module.exports = class {
2424
if (!res.success) return reject(errorHandler(res.message));
2525
return resolve(res);
2626
})
27-
.catch(err => reject(err));
27+
.catch((err) => reject(err));
2828
});
2929
}
3030
};

src/error-handler/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
module.exports = errMessage => new Error(`PhaxioAPIError: ${errMessage}`);
1+
module.exports = (errMessage) => new Error(`PhaxioAPIError: ${errMessage}`);

src/faxes/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ module.exports = class {
110110
// eslint-disable-next-line max-len
111111
return resolve(new Fax(this.apiKey, this.apiSecret, this.url, res.success, res.message, res.data));
112112
})
113-
.catch(err => reject(err));
113+
.catch((err) => reject(err));
114114
});
115115
}
116116

@@ -142,7 +142,7 @@ module.exports = class {
142142
if (!res.success) return reject(errorHandler(res.message));
143143
return resolve(res);
144144
})
145-
.catch(err => reject(err));
145+
.catch((err) => reject(err));
146146
});
147147
}
148148

@@ -181,7 +181,7 @@ module.exports = class {
181181
if (!res.success) return reject(errorHandler(res.message));
182182
return resolve(res);
183183
})
184-
.catch(err => reject(err));
184+
.catch((err) => reject(err));
185185
});
186186
}
187187
};

src/faxes/shared-methods.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function cancel(url, id, auth, agentOptions) {
1414
if (!res.success) return reject(errorHandler(res.message));
1515
return resolve(res);
1616
})
17-
.catch(err => reject(err));
17+
.catch((err) => reject(err));
1818
});
1919
}
2020

@@ -38,7 +38,7 @@ function resend(url, id, auth, options = { id: null, callback_url: null }, agent
3838
if (!res.success) return reject(errorHandler(res.message));
3939
return resolve(res);
4040
})
41-
.catch(err => reject(err));
41+
.catch((err) => reject(err));
4242
});
4343
}
4444

@@ -55,7 +55,7 @@ function testDelete(url, id, auth, agentOptions) {
5555
if (!res.success) return reject(errorHandler(res.message));
5656
return resolve(res);
5757
})
58-
.catch(err => reject(err));
58+
.catch((err) => reject(err));
5959
});
6060
}
6161

@@ -72,7 +72,7 @@ function getInfo(url, id, auth, agentOptions) {
7272
if (!res.success) return reject(errorHandler(res.message));
7373
return resolve(res);
7474
})
75-
.catch(err => reject(err));
75+
.catch((err) => reject(err));
7676
});
7777
}
7878

@@ -92,11 +92,11 @@ function getFile(url, id, auth, options = { id: null, thumbnail: null }, agentOp
9292
encoding: null,
9393
};
9494

95-
if (thumbnail !== null) req.qs.thumbnail = thumbnail;
95+
if (thumbnail !== null) req.qs = { thumbnail };
9696

9797
request(req)
98-
.then(response => resolve(response))
99-
.catch(err => reject(err));
98+
.then((response) => resolve(response))
99+
.catch((err) => reject(err));
100100
});
101101
}
102102

@@ -113,7 +113,7 @@ function deleteFile(url, id, auth, agentOptions) {
113113
if (!res.success) return reject(errorHandler(res.message));
114114
return resolve(res);
115115
})
116-
.catch(err => reject(err));
116+
.catch((err) => reject(err));
117117
});
118118
}
119119

src/phax-code/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ module.exports = class {
3333
if (!res.success) return reject(errorHandler(res.message));
3434
return resolve(res);
3535
})
36-
.catch(err => reject(err));
36+
.catch((err) => reject(err));
3737
});
3838
}
3939

@@ -60,7 +60,7 @@ module.exports = class {
6060
if (!res.success) return reject(errorHandler(res.message));
6161
return resolve(res);
6262
})
63-
.catch(err => reject(err));
63+
.catch((err) => reject(err));
6464
});
6565
}
6666
};

src/phone-number/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module.exports = class {
2424
if (!res.success) return reject(errorHandler(res.message));
2525
return resolve(res);
2626
})
27-
.catch(err => reject(err));
27+
.catch((err) => reject(err));
2828
});
2929
}
3030

@@ -50,7 +50,7 @@ module.exports = class {
5050
if (!res.success) return reject(errorHandler(res.message));
5151
return resolve(res);
5252
})
53-
.catch(err => reject(err));
53+
.catch((err) => reject(err));
5454
});
5555
}
5656

@@ -67,7 +67,7 @@ module.exports = class {
6767
if (!res.success) return reject(errorHandler(res.message));
6868
return resolve(res);
6969
})
70-
.catch(err => reject(err));
70+
.catch((err) => reject(err));
7171
});
7272
}
7373

@@ -93,7 +93,7 @@ module.exports = class {
9393
if (!res.success) return reject(errorHandler(res.message));
9494
return resolve(res);
9595
})
96-
.catch(err => reject(err));
96+
.catch((err) => reject(err));
9797
});
9898
}
9999
};

src/public/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ module.exports = class {
3636
if (!res.success) return reject(errorHandler(res.message));
3737
return resolve(res);
3838
})
39-
.catch(err => reject(err));
39+
.catch((err) => reject(err));
4040
});
4141
}
4242

@@ -55,7 +55,7 @@ module.exports = class {
5555
if (!res.success) return reject(errorHandler(res.message));
5656
return resolve(res);
5757
})
58-
.catch(err => reject(err));
58+
.catch((err) => reject(err));
5959
});
6060
}
6161
};

test/faxes/shared-methods.test.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,14 @@ describe('shared methods', function () { // eslint-disable-line func-names
8787
});
8888

8989
describe('function: getFile', () => {
90+
it('should get a fax\'s thumbnail', () => {
91+
return getFile(url, firstFax, auth, { id: firstFax, thumbnail: 'l' })
92+
.then((gf) => {
93+
expect(Buffer.isBuffer(gf)).to.be.ok();
94+
})
95+
.catch((err) => { throw err; });
96+
});
97+
9098
it('should get a fax\'s file', () => {
9199
return getFile(url, firstFax, auth, { id: firstFax })
92100
.then((gf) => {

0 commit comments

Comments
 (0)