Merge pull request #43 from yujideveloper/bugfix/handle-response

Handle service unavailable error

Author: jtnegrotto

lib/phaxio/client.rb

@@ -52,13 +52,17 @@ def conn
       def handle_response response
         content_type = response.headers[:content_type]
 
-        if content_type.start_with? 'application/json'
-          body = JSON.parse(response.body).with_indifferent_access
+        if content_type
+          if content_type.start_with? 'application/json'
+            body = JSON.parse(response.body).with_indifferent_access
+          else
+            extension = MimeTypeHelper.extension_for_mimetype content_type
+            filename = File.join Dir.tmpdir, tmpname(extension)
+            File.open(filename, 'wb') { |file| file.write response.body }
+            body = {'success' => response.success?, 'data' => File.open(filename, 'rb')}
+          end
         else
-          extension = MimeTypeHelper.extension_for_mimetype content_type
-          filename = File.join Dir.tmpdir, tmpname(extension)
-          File.open(filename, 'wb') { |file| file.write response.body }
-          body = {'success' => response.success?, 'data' => File.open(filename, 'rb')}
+          body = {}
         end
 
         if response.success?
@@ -85,6 +89,8 @@ def handle_response response
             raise Error::InvalidRequestError, "#{status}: #{message}"
           when 429
             raise Error::RateLimitExceededError, "#{status}: #{message}"
+          when 503
+            raise Error::ServiceUnavailableError, "#{status}: #{message}"
           else
             raise Error::GeneralError, "#{status}: #{message}"
           end

lib/phaxio/error.rb

@@ -6,6 +6,7 @@ module Error
       NotFoundError
       InvalidRequestError
       RateLimitExceededError
+      ServiceUnavailableError
       GeneralError
       ApiConnectionError
     ].each { |error_klass_name| const_set error_klass_name, Class.new(PhaxioError) }

spec/client_spec.rb

@@ -19,6 +19,16 @@ def test_response status_code, message: 'This is a test.'
     )
   end
 
+  def test_response_503
+    instance_double(
+      Faraday::Response,
+      status: 503,
+      success?: false,
+      headers: {},
+      body: nil
+    )
+  end
+
   describe 'making a request' do
     it 'sends the request to Phaxio' do
       endpoint = 'public/countries/'
@@ -118,6 +128,13 @@ def test_response status_code, message: 'This is a test.'
       }.to raise_error(Phaxio::Error::RateLimitExceededError, '429: This is a test.')
     end
 
+    it 'raises a service unavailable error if the response status is 503' do
+      expect(test_connection).to receive(:get) { test_response_503 }
+      expect {
+        client.request :get, 'test'
+      }.to raise_error(Phaxio::Error::ServiceUnavailableError, '503: ')
+    end
+
     it 'raises a general error for if the response status is 5XX' do
       expect(test_connection).to receive(:get) { test_response 500 }
       expect {