Skip to content

Commit 1035f5d

Browse files
committed
fix: showing mobile device is not supported message instead of browser not supported
1 parent 59dbe2c commit 1035f5d

2 files changed

Lines changed: 11 additions & 1 deletion

File tree

src/extensions/default/Phoenix/main.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ define(function (require, exports, module) {
3333
Strings = brackets.getModule("strings"),
3434
Dialogs = brackets.getModule("widgets/Dialogs"),
3535
Mustache = brackets.getModule("thirdparty/mustache/mustache"),
36+
DefaultDialogs = brackets.getModule("widgets/DefaultDialogs"),
3637
unSupportedBrowserTemplate = require("text!html/unsupported-browser.html");
3738

3839
const PERSIST_STORAGE_DIALOG_DELAY_SECS = 60000;
@@ -57,6 +58,14 @@ define(function (require, exports, module) {
5758
return;
5859
}
5960
unsupportedBrowserDialogShown = true;
61+
if(Phoenix.browser.isMobile || Phoenix.browser.isTablet){
62+
Dialogs.showModalDialog(
63+
DefaultDialogs.DIALOG_ID_ERROR,
64+
Strings.UNSUPPORTED_BROWSER,
65+
Strings.UNSUPPORTED_BROWSER_MOBILE
66+
);
67+
return;
68+
}
6069
let templateVars = {
6170
Strings: Strings,
6271
surveyURL: "https://s.surveyplanet.com/6208d1eccd51c561fc8e59ca"

src/nls/root/strings.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -922,9 +922,10 @@ define({
922922

923923
// Phoenix extension
924924
"UNSUPPORTED_BROWSER": "Browser Is Not Supported",
925+
"UNSUPPORTED_BROWSER_MOBILE": "Mobile and Tablet devices are currently not fully supported. You may close this dialogue, but some features in Phoenix will not work in this browser.",
925926
"UNSUPPORTED_BROWSER_OPEN_FOLDER": "Browser does not support Open folder. Please use Chrome, Edge or Opera to open local folders.",
926927
"UNSUPPORTED_BROWSER_MESSAGE_LINE1": "Please use one of the supported browsers below.",
927-
"UNSUPPORTED_BROWSER_MESSAGE_LINE2": " We are working hard to make Phoenix available in more browsers. You may close this dialogue, but some features in Phoenix won't work in this browser.",
928+
"UNSUPPORTED_BROWSER_MESSAGE_LINE2": " We are working hard to make Phoenix available in more browsers. You may close this dialogue, but some features in Phoenix will not work in this browser.",
928929
"CANNOT_PUBLISH_LARGE_PROJECT": "Cannot Publish Large Project",
929930
"CANNOT_PUBLISH_LARGE_PROJECT_MESSAGE": "Phoenix is still in experimental alpha. We have not yet enabled sync of projects with greater than 500 files.",
930931
"SHARE_WEBSITE": "Publish and Share Website?",

0 commit comments

Comments
 (0)