Skip to content

Commit df10896

Browse files
committed
chore: remove the preference for spacing handles
1 parent 9ac4d03 commit df10896

1 file changed

Lines changed: 6 additions & 26 deletions

File tree

  • src/extensionsIntegrated/Phoenix-live-preview

src/extensionsIntegrated/Phoenix-live-preview/main.js

Lines changed: 6 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,11 @@ define(function (require, exports, module) {
110110
description: Strings.LIVE_DEV_SETTINGS_SHOW_RULER_LINES_PREFERENCE
111111
});
112112

113-
// live preview spacing handles preference (show/hide spacing handles on element selection)
114-
const PREFERENCE_SHOW_SPACING_HANDLES = CONSTANTS.PREFERENCE_SHOW_SPACING_HANDLES;
115-
PreferencesManager.definePreference(PREFERENCE_SHOW_SPACING_HANDLES, "boolean", true, {
116-
description: Strings.LIVE_DEV_SETTINGS_SHOW_SPACING_HANDLES_PREFERENCE
117-
});
113+
// Spacing handles preference disabled for this release (incomplete feature).
114+
// const PREFERENCE_SHOW_SPACING_HANDLES = CONSTANTS.PREFERENCE_SHOW_SPACING_HANDLES;
115+
// PreferencesManager.definePreference(PREFERENCE_SHOW_SPACING_HANDLES, "boolean", true, {
116+
// description: Strings.LIVE_DEV_SETTINGS_SHOW_SPACING_HANDLES_PREFERENCE
117+
// });
118118

119119
// live preview sync source and preview preference
120120
const PREFERENCE_LIVE_PREVIEW_SYNC = CONSTANTS.PREFERENCE_LIVE_PREVIEW_SYNC;
@@ -359,7 +359,6 @@ define(function (require, exports, module) {
359359
if (isEditFeaturesActive && isEditMode) {
360360
items.push(Strings.LIVE_PREVIEW_EDIT_HIGHLIGHT_ON);
361361
items.push(Strings.LIVE_PREVIEW_SHOW_RULER_LINES);
362-
items.push(Strings.LIVE_PREVIEW_SHOW_SPACING_HANDLES);
363362
}
364363

365364
$dropdown = new DropdownButton.DropdownButton("", items, function(item, index) {
@@ -398,12 +397,6 @@ define(function (require, exports, module) {
398397
return `✓ ${Strings.LIVE_PREVIEW_SHOW_RULER_LINES}`;
399398
}
400399
return `${'\u00A0'.repeat(4)}${Strings.LIVE_PREVIEW_SHOW_RULER_LINES}`;
401-
} else if (item === Strings.LIVE_PREVIEW_SHOW_SPACING_HANDLES) {
402-
const isEnabled = PreferencesManager.get(PREFERENCE_SHOW_SPACING_HANDLES);
403-
if(isEnabled) {
404-
return `✓ ${Strings.LIVE_PREVIEW_SHOW_SPACING_HANDLES}`;
405-
}
406-
return `${'\u00A0'.repeat(4)}${Strings.LIVE_PREVIEW_SHOW_SPACING_HANDLES}`;
407400
}
408401
return item;
409402
});
@@ -466,15 +459,6 @@ define(function (require, exports, module) {
466459
const currentValue = PreferencesManager.get(PREFERENCE_SHOW_RULER_LINES);
467460
PreferencesManager.set(PREFERENCE_SHOW_RULER_LINES, !currentValue);
468461
return; // Don't dismiss highlights for this option
469-
} else if (item === Strings.LIVE_PREVIEW_SHOW_SPACING_HANDLES) {
470-
// Don't allow spacing handles toggle if edit features are not active
471-
if (!isEditFeaturesActive) {
472-
return;
473-
}
474-
// Toggle spacing handles on/off
475-
const currentValue = PreferencesManager.get(PREFERENCE_SHOW_SPACING_HANDLES);
476-
PreferencesManager.set(PREFERENCE_SHOW_SPACING_HANDLES, !currentValue);
477-
return; // Don't dismiss highlights for this option
478462
}
479463
});
480464

@@ -1273,17 +1257,13 @@ define(function (require, exports, module) {
12731257
PreferencesManager.on("change", PREFERENCE_SHOW_RULER_LINES, function() {
12741258
LiveDevelopment.updateRulerLinesConfig();
12751259
});
1276-
PreferencesManager.on("change", PREFERENCE_SHOW_SPACING_HANDLES, function() {
1277-
LiveDevelopment.updateSpacingHandlesConfig();
1278-
});
12791260
PreferencesManager.on("change", PREFERENCE_LIVE_PREVIEW_SYNC, function() {
12801261
LiveDevelopment.updateSyncConfig();
12811262
});
12821263

1283-
// Initialize element highlight, ruler lines, spacing handles, and sync config on startup
1264+
// Initialize element highlight, ruler lines, and sync config on startup
12841265
LiveDevelopment.updateElementHighlightConfig();
12851266
LiveDevelopment.updateRulerLinesConfig();
1286-
LiveDevelopment.updateSpacingHandlesConfig();
12871267
LiveDevelopment.updateSyncConfig();
12881268

12891269
LiveDevelopment.openLivePreview();

0 commit comments

Comments
 (0)