Merge pull request #40 from pheuberger/claude/increase-code-coverage-UPtW4

Add comprehensive test suite for custom hooks

Author: pheuberger

src/hooks/useBookmarkFilters.test.js

@@ -0,0 +1,135 @@
+/**
+ * useBookmarkFilters Tests
+ */
+
+import { describe, it, expect, vi, afterEach } from 'vitest'
+import { renderHook, act } from '@testing-library/react'
+import { useBookmarkFilters } from './useBookmarkFilters.js'
+
+const bookmarks = [
+  { _id: 'b1', title: 'Zebra', url: 'https://z.com', description: '', tags: ['animals'], readLater: true, inbox: false, createdAt: 100, updatedAt: 200 },
+  { _id: 'b2', title: 'Apple', url: 'https://a.com', description: '', tags: ['fruit'], readLater: false, inbox: true, createdAt: 200, updatedAt: 100 },
+  { _id: 'b3', title: 'Mango', url: 'https://m.com', description: '', tags: ['fruit'], readLater: false, inbox: false, createdAt: 300, updatedAt: 300 },
+]
+
+describe('useBookmarkFilters', () => {
+  afterEach(() => {
+    vi.useRealTimers()
+  })
+
+  it('returns all bookmarks by default', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+    expect(result.current.filterView).toBe('all')
+    expect(result.current.filteredBookmarks).toHaveLength(3)
+  })
+
+  it('sorts by recent (default)', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+    expect(result.current.sortBy).toBe('recent')
+    expect(result.current.filteredBookmarks[0]._id).toBe('b3') // createdAt 300
+    expect(result.current.filteredBookmarks[2]._id).toBe('b1') // createdAt 100
+  })
+
+  it('sorts by oldest', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+
+    act(() => result.current.setSortBy('oldest'))
+    expect(result.current.filteredBookmarks[0]._id).toBe('b1')
+    expect(result.current.filteredBookmarks[2]._id).toBe('b3')
+  })
+
+  it('sorts by title', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+
+    act(() => result.current.setSortBy('title'))
+    expect(result.current.filteredBookmarks[0].title).toBe('Apple')
+    expect(result.current.filteredBookmarks[2].title).toBe('Zebra')
+  })
+
+  it('sorts by updated', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+
+    act(() => result.current.setSortBy('updated'))
+    expect(result.current.filteredBookmarks[0]._id).toBe('b3') // updatedAt 300
+  })
+
+  it('goToReadLater filters for readLater only', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+
+    act(() => result.current.goToReadLater())
+    expect(result.current.filterView).toBe('read-later')
+    expect(result.current.filteredBookmarks).toHaveLength(1)
+    expect(result.current.filteredBookmarks[0]._id).toBe('b1')
+  })
+
+  it('goToInbox filters for inbox only', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+
+    act(() => result.current.goToInbox())
+    expect(result.current.filterView).toBe('inbox')
+    expect(result.current.filteredBookmarks).toHaveLength(1)
+    expect(result.current.filteredBookmarks[0]._id).toBe('b2')
+  })
+
+  it('handleTagSelect filters by tag', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+
+    act(() => result.current.handleTagSelect('fruit'))
+    expect(result.current.filterView).toBe('tag')
+    expect(result.current.selectedTag).toBe('fruit')
+    expect(result.current.filteredBookmarks).toHaveLength(2)
+    expect(result.current.filteredBookmarks.every(b => b.tags.includes('fruit'))).toBe(true)
+  })
+
+  it('handleTagClick filters by tag', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+
+    act(() => result.current.handleTagClick('animals'))
+    expect(result.current.filterView).toBe('tag')
+    expect(result.current.selectedTag).toBe('animals')
+    expect(result.current.filteredBookmarks).toHaveLength(1)
+  })
+
+  it('handleFilterChange sets filter view and clears tag', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+
+    // First set a tag filter
+    act(() => result.current.handleTagSelect('fruit'))
+    expect(result.current.selectedTag).toBe('fruit')
+
+    // Then change filter - should clear tag
+    act(() => result.current.handleFilterChange('all'))
+    expect(result.current.filterView).toBe('all')
+    expect(result.current.selectedTag).toBeNull()
+  })
+
+  it('goToAllBookmarks resets everything', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+
+    act(() => result.current.goToReadLater())
+    act(() => result.current.setSearchQuery('test'))
+
+    act(() => result.current.goToAllBookmarks())
+    expect(result.current.filterView).toBe('all')
+    expect(result.current.selectedTag).toBeNull()
+    expect(result.current.searchQuery).toBe('')
+  })
+
+  it('setSearchQuery updates search query state', () => {
+    const { result } = renderHook(() => useBookmarkFilters(bookmarks))
+
+    act(() => result.current.setSearchQuery('hello'))
+    expect(result.current.searchQuery).toBe('hello')
+  })
+
+  it('handles bookmarks with missing tags array', () => {
+    const messyBookmarks = [
+      { _id: 'b1', title: 'No Tags', url: 'https://x.com', tags: null, readLater: false, inbox: false, createdAt: 100, updatedAt: 100 },
+    ]
+    const { result } = renderHook(() => useBookmarkFilters(messyBookmarks))
+
+    // Should not crash when filtering by tag
+    act(() => result.current.handleTagSelect('test'))
+    expect(result.current.filteredBookmarks).toHaveLength(0)
+  })
+})

src/hooks/useBookmarkKeyboardNav.test.js

@@ -0,0 +1,221 @@
+/**
+ * useBookmarkKeyboardNav Tests
+ */
+
+import { describe, it, expect, vi, beforeEach } from 'vitest'
+import { renderHook, act } from '@testing-library/react'
+import { useBookmarkKeyboardNav } from './useBookmarkKeyboardNav.js'
+
+const bookmarks = [
+  { _id: 'b1', title: 'A' },
+  { _id: 'b2', title: 'B' },
+  { _id: 'b3', title: 'C' },
+]
+
+function setup(bm = bookmarks, opts = {}) {
+  const defaultOpts = {
+    filterView: 'all',
+    inboxViewRef: { current: null },
+    selectedTag: null,
+    debouncedSearchQuery: '',
+    ...opts,
+  }
+  return renderHook(() => useBookmarkKeyboardNav(bm, defaultOpts))
+}
+
+describe('useBookmarkKeyboardNav', () => {
+  it('starts with no selection', () => {
+    const { result } = setup()
+    expect(result.current.selectedIndex).toBe(-1)
+    expect(result.current.hoveredIndex).toBe(-1)
+    expect(result.current.keyboardNavActive).toBe(false)
+  })
+
+  it('selectNext moves to first item from no selection', () => {
+    const { result } = setup()
+
+    act(() => result.current.selectNext())
+    expect(result.current.selectedIndex).toBe(0)
+    expect(result.current.keyboardNavActive).toBe(true)
+  })
+
+  it('selectNext advances through items', () => {
+    const { result } = setup()
+
+    act(() => result.current.selectNext())
+    expect(result.current.selectedIndex).toBe(0)
+
+    act(() => result.current.selectNext())
+    expect(result.current.selectedIndex).toBe(1)
+
+    act(() => result.current.selectNext())
+    expect(result.current.selectedIndex).toBe(2)
+  })
+
+  it('selectNext does not go past last item', () => {
+    const { result } = setup()
+
+    act(() => result.current.selectNext())
+    act(() => result.current.selectNext())
+    act(() => result.current.selectNext())
+    act(() => result.current.selectNext()) // attempt to go past end
+
+    expect(result.current.selectedIndex).toBe(2) // stays at last
+  })
+
+  it('selectPrev moves to last item from no selection', () => {
+    const { result } = setup()
+
+    act(() => result.current.selectPrev())
+    expect(result.current.selectedIndex).toBe(2) // last
+    expect(result.current.keyboardNavActive).toBe(true)
+  })
+
+  it('selectPrev moves backward through items', () => {
+    const { result } = setup()
+
+    act(() => result.current.selectPrev())
+    expect(result.current.selectedIndex).toBe(2)
+
+    act(() => result.current.selectPrev())
+    expect(result.current.selectedIndex).toBe(1)
+
+    act(() => result.current.selectPrev())
+    expect(result.current.selectedIndex).toBe(0)
+  })
+
+  it('selectPrev does not go below 0', () => {
+    const { result } = setup()
+
+    act(() => result.current.selectPrev())
+    act(() => result.current.selectPrev())
+    act(() => result.current.selectPrev())
+    act(() => result.current.selectPrev()) // attempt to go below 0
+
+    expect(result.current.selectedIndex).toBe(0)
+  })
+
+  it('goToTop selects first item', () => {
+    const { result } = setup()
+
+    act(() => result.current.goToTop())
+    expect(result.current.selectedIndex).toBe(0)
+  })
+
+  it('goToBottom selects last item', () => {
+    const { result } = setup()
+
+    act(() => result.current.goToBottom())
+    expect(result.current.selectedIndex).toBe(2)
+  })
+
+  it('getSelectedBookmark returns null when no selection', () => {
+    const { result } = setup()
+    expect(result.current.getSelectedBookmark()).toBeNull()
+  })
+
+  it('getSelectedBookmark returns the selected bookmark', () => {
+    const { result } = setup()
+
+    act(() => result.current.selectNext())
+    expect(result.current.getSelectedBookmark()).toEqual(bookmarks[0])
+  })
+
+  it('handleBookmarkHover sets hovered index', () => {
+    const { result } = setup()
+
+    act(() => result.current.handleBookmarkHover(1))
+    expect(result.current.hoveredIndex).toBe(1)
+  })
+
+  it('handleBookmarkHover deactivates keyboard nav', () => {
+    const { result } = setup()
+
+    // First activate keyboard nav
+    act(() => result.current.selectNext())
+    expect(result.current.keyboardNavActive).toBe(true)
+
+    // Hover should deactivate keyboard nav
+    act(() => result.current.handleBookmarkHover(2))
+    expect(result.current.keyboardNavActive).toBe(false)
+    expect(result.current.selectedIndex).toBe(-1)
+  })
+
+  it('selectNext starts at hovered index if available', () => {
+    const { result } = setup()
+
+    act(() => result.current.handleBookmarkHover(1))
+    act(() => result.current.selectNext())
+    expect(result.current.selectedIndex).toBe(1)
+  })
+
+  it('delegates to inboxViewRef when filterView is inbox', () => {
+    const inboxMock = {
+      selectNext: vi.fn(),
+      selectPrev: vi.fn(),
+      goToTop: vi.fn(),
+      goToBottom: vi.fn(),
+    }
+    const { result } = setup(bookmarks, {
+      filterView: 'inbox',
+      inboxViewRef: { current: inboxMock },
+    })
+
+    act(() => result.current.selectNext())
+    expect(inboxMock.selectNext).toHaveBeenCalled()
+
+    act(() => result.current.selectPrev())
+    expect(inboxMock.selectPrev).toHaveBeenCalled()
+
+    act(() => result.current.goToTop())
+    expect(inboxMock.goToTop).toHaveBeenCalled()
+
+    act(() => result.current.goToBottom())
+    expect(inboxMock.goToBottom).toHaveBeenCalled()
+  })
+
+  it('selectNext with empty bookmarks stays at -1', () => {
+    const { result } = setup([])
+
+    act(() => result.current.selectNext())
+    expect(result.current.selectedIndex).toBe(-1)
+  })
+
+  it('selectPrev with empty bookmarks stays at -1', () => {
+    const { result } = setup([])
+
+    act(() => result.current.selectPrev())
+    expect(result.current.selectedIndex).toBe(-1)
+  })
+
+  it('goToTop with empty bookmarks does nothing', () => {
+    const { result } = setup([])
+
+    act(() => result.current.goToTop())
+    expect(result.current.selectedIndex).toBe(-1)
+  })
+
+  it('goToBottom with empty bookmarks does nothing', () => {
+    const { result } = setup([])
+
+    act(() => result.current.goToBottom())
+    expect(result.current.selectedIndex).toBe(-1)
+  })
+
+  it('suppressHoverBriefly ignores hover temporarily', () => {
+    vi.useFakeTimers()
+    const { result } = setup()
+
+    act(() => result.current.suppressHoverBriefly())
+    act(() => result.current.handleBookmarkHover(1))
+    // Should be ignored
+    expect(result.current.hoveredIndex).toBe(-1)
+
+    // After timeout, should work again
+    act(() => vi.advanceTimersByTime(200))
+    act(() => result.current.handleBookmarkHover(2))
+    expect(result.current.hoveredIndex).toBe(2)
+
+    vi.useRealTimers()
+  })
+})