[~]: use &references for string|array parameter from private methods

Author: voku

src/EDI/Encoder.php

@@ -159,7 +159,7 @@ public function encodeSegment($row): string
      *
      * @return string
      */
-    private function escapeValue($str): string
+    private function escapeValue(&$str): string
     {
         $search = [
             $this->symbRel,

src/EDI/Interpreter.php

@@ -183,7 +183,7 @@ public function prepare($parsed): array
      *
      * @return array
      */
-    private function splitMessages($parsed, &$errors): array
+    private function splitMessages(&$parsed, &$errors): array
     {
         // init
         $messages = [];
@@ -267,7 +267,7 @@ private function splitMessages($parsed, &$errors): array
      *
      * @return array
      */
-    private function loopMessage($message, $xml, &$errors): array
+    private function loopMessage(&$message, $xml, &$errors): array
     {
         // init
         $groupedEdi = [];
@@ -363,7 +363,7 @@ private function processXmlGroup($elm, &$message, &$segmentIdx, &$array, &$error
      *
      * @return void
      */
-    private function processXmlSegment($elm, $message, &$segmentIdx, &$array, &$errors)
+    private function processXmlSegment($elm, &$message, &$segmentIdx, &$array, &$errors)
     {
         $segmentVisited = false;
         for ($i = 0; $i < $elm['maxrepeat']; $i++) {
@@ -412,7 +412,7 @@ private function processXmlSegment($elm, $message, &$segmentIdx, &$array, &$erro
      *
      * @return void
      */
-    private function doAddArray(&$array, $jsonMessage)
+    private function doAddArray(&$array, &$jsonMessage)
     {
         if (isset($array[$jsonMessage['key']])) {
             if (
@@ -440,7 +440,7 @@ private function doAddArray(&$array, $jsonMessage)
      *
      * @return array
      */
-    private function processSegment($segment, &$xmlMap, $segmentIdx, &$errors = null): array
+    private function processSegment(&$segment, &$xmlMap, $segmentIdx, &$errors = null): array
     {
         $id = $segment[0];
 
@@ -535,10 +535,10 @@ private function processSegment($segment, &$xmlMap, $segmentIdx, &$errors = null
      *
      * @return array
      */
-    private function processService($segments): array
+    private function processService(&$segments): array
     {
         $processed = [];
-        foreach ($segments as $seg) {
+        foreach ($segments as &$seg) {
             $jsonsegment = $this->processSegment($seg, $this->xmlSvc, null);
             $processed[$jsonsegment['key']] = $jsonsegment['value'];
         }

src/EDI/Parser.php

@@ -111,6 +111,7 @@ public function __construct($url = null)
         if ($this->unaChecked !== false) {
             $this->resetUNA();
         }
+
         if ($this->unbChecked !== false) {
             $this->resetUNB();
         }
@@ -122,25 +123,25 @@ public function __construct($url = null)
             return;
         }
         if (\is_array($url)) {
-            /**
-             * Object constructed with an array as argument
-             */
+            //
+            // Object constructed with an array as argument
+            //
             if (\count($url) == 1) {
                 $url = $this->unwrap($url[0]);
             }
             $this->rawSegments = $url;
             /** @noinspection UnusedFunctionResultInspection */
             $this->parse($url);
         } elseif (file_exists($url)) {
-            /**
-             * Object constructed with a path to a file as argument
-             */
+            //
+            // Object constructed with a path to a file as argument
+            //
             /** @noinspection UnusedFunctionResultInspection */
             $this->load($url);
         } else {
-            /**
-             * Object constructed with a string as argument
-             */
+            //
+            // Object constructed with a string as argument
+            //
             /** @noinspection UnusedFunctionResultInspection */
             $this->loadString($url);
         }
@@ -159,17 +160,13 @@ public function parse(&$file2): array
         for ($i = 1; $i <= $t; $i++) {
             $line = \array_shift($file2);
 
-            /**
-             * Null byte and carriage return removal (CR+LF)
-             */
+            // Null byte and carriage return removal (CR+LF)
             $line = \preg_replace('#[\x00\r\n]#', '', $line);
             if (\preg_match($this->stripChars, $line)) {
                 $this->errors[] = "There's a not printable character on line " . $i . ": " . $line;
             }
 
-            /**
-             * Basic sanitization, remove non printable chars
-             */
+            // Basic sanitization, remove non printable chars
             $line = \preg_replace($this->stripChars, '', \trim($line));
             if (\strlen($line) < 2) {
                 continue;
@@ -316,11 +313,12 @@ public function analyseUNH($line)
      *
      * @return string[]
      */
-    private function unwrap($string): array
+    private function unwrap(&$string): array
     {
         if (!$this->unaChecked && \strpos($string, "UNA") === 0) {
             $this->analyseUNA(\preg_replace("#^UNA#", "", substr($string, 0, 9)));
         }
+
         if (!$this->unbChecked && \strpos($string, "UNB") === 0) {
             $this->analyseUNB(\preg_replace("#^UNB\+#", "", substr($string, 0, 8)));
         }
@@ -350,7 +348,7 @@ private function unwrap($string): array
      *
      * @return array[]|string[]
      */
-    private function splitSegment($str): array
+    private function splitSegment(&$str): array
     {
         // remove ending symbEnd
         $str = \trim(
@@ -405,7 +403,7 @@ private function splitSegment($str): array
      *
      * @return mixed
      */
-    private function splitData($str)
+    private function splitData(&$str)
     {
         $replace = function ($string) {
             $regex = self::$DELIMITER . $this->symbRel . "(?=" . $this->symbRel . ")|" . $this->symbRel . "(?=" . $this->sepData . ")|" . $this->symbRel . "(?=" . $this->sepComp . ")|" . $this->symbRel . "(?=" . $this->symbEnd . ")" . self::$DELIMITER;