Merge pull request #44 from veewee/binding-style-improvements

Detect binding-style from both soap:operation and soap:binding

Author: veewee

src/Metadata/Converter/Methods/Configurator/Binding/SoapBindingConfigurator.php

@@ -20,6 +20,7 @@ public function __invoke(Method $method, Binding $binding): Method
         return $method->withMeta(
             static fn (MethodMeta $meta): MethodMeta => $meta
                 ->withTransport($implementation->transport->value)
+                ->withBindingStyle($implementation->style?->value ?? $meta->bindingStyle()->unwrapOr(null))
         );
     }
 }

src/Metadata/Converter/Methods/Configurator/Operation/SoapBindingOperationConfigurator.php

@@ -24,7 +24,7 @@ public function __invoke(Method $method, BindingOperation $operation): Method
             ->withSoapVersion($implementation->version->value)
             ->withAction($implementation->action)
             ->withOperationName($operation->name)
-            ->withBindingStyle($implementation->style->value)
+            ->withBindingStyle($implementation->style?->value ?? $meta->bindingStyle()->unwrapOr(null))
             ->withInputBindingUsage($this->collectBindingUsageForMessage($operation->input))
             ->withInputNamespace($this->collectMessageNamespace($operation->input))
             ->withInputEncodingStyle($this->collectMessageEncodingStyle($operation->input))

src/Model/Definitions/Implementation/Binding/SoapBinding.php

@@ -3,6 +3,7 @@
 
 namespace Soap\WsdlReader\Model\Definitions\Implementation\Binding;
 
+use Soap\WsdlReader\Model\Definitions\BindingStyle;
 use Soap\WsdlReader\Model\Definitions\SoapVersion;
 use Soap\WsdlReader\Model\Definitions\TransportType;
 
@@ -11,6 +12,7 @@ final class SoapBinding implements BindingImplementation
     public function __construct(
         public readonly SoapVersion $version,
         public readonly TransportType $transport,
+        public readonly ?BindingStyle $style,
     ) {
     }
 }

src/Model/Definitions/Implementation/Operation/SoapOperation.php

@@ -11,7 +11,7 @@ final class SoapOperation implements OperationImplementation
     public function __construct(
         public readonly SoapVersion $version,
         public readonly string $action,
-        public readonly BindingStyle $style,
+        public readonly ?BindingStyle $style,
     ) {
     }
 }

src/Parser/Strategy/SoapStrategy.php

@@ -26,7 +26,8 @@ public function parseBindingImplementation(Document $wsdl, DOMElement $binding):
     {
         return new SoapBinding(
             version: $this->parseVersionFromNode($wsdl, $binding),
-            transport: TransportType::from($binding->getAttribute('transport'))
+            transport: TransportType::from($binding->getAttribute('transport')),
+            style: BindingStyle::tryFromCaseInsensitive($binding->getAttribute('style')),
         );
     }
 
@@ -35,7 +36,7 @@ public function parseOperationImplementation(Document $wsdl, DOMElement $operati
         return new SoapOperation(
             version: $this->parseVersionFromNode($wsdl, $operation),
             action: $operation->getAttribute('soapAction'),
-            style: BindingStyle::tryFromCaseInsensitive($operation->getAttribute('style')) ?? BindingStyle::DOCUMENT,
+            style: BindingStyle::tryFromCaseInsensitive($operation->getAttribute('style')),
         );
     }