Skip to content

Commit 07d4479

Browse files
committed
Refactoring the Client a bit more, removing arguments that can be dealt with otherwise. Adjusted examples to reflect this change.
1 parent 7f9605a commit 07d4479

29 files changed

Lines changed: 104 additions & 134 deletions

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,15 +106,15 @@ $client = new \Tmdb\Client($token);
106106
If you'd like to make unsecure requests ( by __default__ we use secure requests ).
107107

108108
```php
109-
$client = new \Tmdb\Client($token, null, false);
109+
$client = new \Tmdb\Client($token, ['secure' => false]);
110110
```
111111

112112
Caching is enabled by default, and uses a slow filesystem handler, which you can either:
113113

114114
Replace the `path` of the storage of, by supplying the option in the client:
115115

116116
```php
117-
$client = new \Tmdb\Client($token, null, true, [
117+
$client = new \Tmdb\Client($token, [
118118
'cache' => [
119119
'enabled' => false,
120120
'path' => '/tmp/php-tmdb-api.log'
@@ -124,7 +124,7 @@ $client = new \Tmdb\Client($token, null, true, [
124124
Or replace the whole implementation with another CacheStorage of Doctrine:
125125

126126
```php
127-
$client = new \Tmdb\Client($token, null, true, [
127+
$client = new \Tmdb\Client($token, [
128128
'cache' => [
129129
'enabled' => false,
130130
'storage' => new \Doctrine\Common\Cache\ArrayCache()
@@ -137,7 +137,7 @@ _This will only keep cache in memory during the length of the request, see the
137137
If you want to add some logging capabilities ( requires `monolog/monolog` ), defaulting to the filesystem;
138138

139139
```php
140-
$client = new \Tmdb\Client($token, null, true, [
140+
$client = new \Tmdb\Client($token, [
141141
'log' => [
142142
'enabled' => true,
143143
'path' => '/var/www/php-tmdb-api.log'
@@ -149,7 +149,7 @@ $client = new \Tmdb\Client($token, null, true, [
149149
However during development you might like some console magic like `ChromePHP` or `FirePHP`;
150150

151151
```php
152-
$client = new \Tmdb\Client($token, null, true, [
152+
$client = new \Tmdb\Client($token, [
153153
'log' => [
154154
'enabled' => true,
155155
'handler' => new \Monolog\Handler\ChromePHPHandler()

UPGRADE-2.0.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
Upgrading to 2.0
2+
----------------
3+
4+
The `Client` constructor has been simplified, and now is initialised as so:
5+
6+
```php
7+
$client = new \Tmdb\Client($apiToken, $options);
8+
```
9+
10+
If you used the old constructor, this is how you define the same options from 2.0 and onward:
11+
12+
```php
13+
$client = new \Tmdb\Client($apiToken, [
14+
'adapter' => new FooBarAdapter(),
15+
'secure' => false,
16+
'
17+
]);
18+
```
19+
20+
If you'd like to set a session for the current request cycle:
21+
22+
```php
23+
$client = new \Tmdb\Client($apiToken, [
24+
'session_token' => new SessionToken(TMDB_SESSION_TOKEN)
25+
]);
26+
```

examples/account/api/account.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@
1414
require_once '../../../apikey.php';
1515

1616
$token = new \Tmdb\ApiToken(TMDB_API_KEY);
17-
$client = new \Tmdb\Client($token);
18-
19-
$sessionToken = new \Tmdb\SessionToken(TMDB_SESSION_TOKEN);
20-
$client->setSessionToken($sessionToken);
17+
$client = new \Tmdb\Client($token, ['session_token' => new \Tmdb\SessionToken(TMDB_SESSION_TOKEN)]);
2118

2219
$account = $client->getAccountApi()->getAccount();
2320

examples/account/api/favorite.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@
1414
require_once '../../../apikey.php';
1515

1616
$token = new \Tmdb\ApiToken(TMDB_API_KEY);
17-
$client = new \Tmdb\Client($token);
18-
19-
$sessionToken = new \Tmdb\SessionToken(TMDB_SESSION_TOKEN);
20-
$client->setSessionToken($sessionToken);
17+
$client = new \Tmdb\Client($token, ['session_token' => new \Tmdb\SessionToken(TMDB_SESSION_TOKEN)]);
2118

2219
$favorite = $client->getAccountApi()->favorite(TMDB_ACCOUNT_ID, 550, true);
2320

examples/account/api/favorite_movies.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@
1414
require_once '../../../apikey.php';
1515

1616
$token = new \Tmdb\ApiToken(TMDB_API_KEY);
17-
$client = new \Tmdb\Client($token);
18-
19-
$sessionToken = new \Tmdb\SessionToken(TMDB_SESSION_TOKEN);
20-
$client->setSessionToken($sessionToken);
17+
$client = new \Tmdb\Client($token, ['session_token' => new \Tmdb\SessionToken(TMDB_SESSION_TOKEN)]);
2118

2219
$favorite_movies = $client->getAccountApi()->getFavoriteMovies(TMDB_ACCOUNT_ID);
2320

examples/account/api/lists.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@
1414
require_once '../../../apikey.php';
1515

1616
$token = new \Tmdb\ApiToken(TMDB_API_KEY);
17-
$client = new \Tmdb\Client($token);
18-
19-
$sessionToken = new \Tmdb\SessionToken(TMDB_SESSION_TOKEN);
20-
$client->setSessionToken($sessionToken);
17+
$client = new \Tmdb\Client($token, ['session_token' => new \Tmdb\SessionToken(TMDB_SESSION_TOKEN)]);
2118

2219
$lists = $client->getAccountApi()->getLists(TMDB_ACCOUNT_ID);
2320

examples/account/api/rated_movies.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@
1414
require_once '../../../apikey.php';
1515

1616
$token = new \Tmdb\ApiToken(TMDB_API_KEY);
17-
$client = new \Tmdb\Client($token);
18-
19-
$sessionToken = new \Tmdb\SessionToken(TMDB_SESSION_TOKEN);
20-
$client->setSessionToken($sessionToken);
17+
$client = new \Tmdb\Client($token, ['session_token' => new \Tmdb\SessionToken(TMDB_SESSION_TOKEN)]);
2118

2219
$rated_movies = $client->getAccountApi()->getRatedMovies(TMDB_ACCOUNT_ID);
2320

examples/account/api/watchlist.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@
1414
require_once '../../../apikey.php';
1515

1616
$token = new \Tmdb\ApiToken(TMDB_API_KEY);
17-
$client = new \Tmdb\Client($token);
18-
19-
$sessionToken = new \Tmdb\SessionToken(TMDB_SESSION_TOKEN);
20-
$client->setSessionToken($sessionToken);
17+
$client = new \Tmdb\Client($token, ['session_token' => new \Tmdb\SessionToken(TMDB_SESSION_TOKEN)]);
2118

2219
$watchlist = $client->getAccountApi()->watchlist(TMDB_ACCOUNT_ID, 97020, true);
2320

examples/account/api/watchlist_movies.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@
1414
require_once '../../../apikey.php';
1515

1616
$token = new \Tmdb\ApiToken(TMDB_API_KEY);
17-
$client = new \Tmdb\Client($token);
18-
19-
$sessionToken = new \Tmdb\SessionToken(TMDB_SESSION_TOKEN);
20-
$client->setSessionToken($sessionToken);
17+
$client = new \Tmdb\Client($token, ['session_token' => new \Tmdb\SessionToken(TMDB_SESSION_TOKEN)]);
2118

2219
$watchlist_movies = $client->getAccountApi()->getMovieWatchlist(TMDB_ACCOUNT_ID);
2320

examples/account/model/account.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@
1414
require_once '../../../apikey.php';
1515

1616
$token = new \Tmdb\ApiToken(TMDB_API_KEY);
17-
$client = new \Tmdb\Client($token);
18-
19-
$sessionToken = new \Tmdb\SessionToken(TMDB_SESSION_TOKEN);
20-
$client->setSessionToken($sessionToken);
17+
$client = new \Tmdb\Client($token, ['session_token' => new \Tmdb\SessionToken(TMDB_SESSION_TOKEN)]);
2118

2219
$accountRepository = new \Tmdb\Repository\AccountRepository($client);
2320
$account = $accountRepository->getAccount();

0 commit comments

Comments
 (0)