Fixes #180; reference birth or death days as YEAR-01-01 instead of using today. (#227)

Author: wtfzdotnet

lib/Tmdb/Model/Person.php

@@ -228,8 +228,22 @@ public function getBirthday()
      */
     public function setBirthday($birthday)
     {
-        if (!$birthday instanceof DateTime) {
-            $birthday = new DateTime($birthday);
+        if (!$birthday instanceof DateTime && !empty($birthday)) {
+            if (ctype_digit($birthday) && strlen(4)) {
+                $birthday = DateTime::createFromFormat(
+                    'Y-m-d',
+                    sprintf('%d-01-01', $birthday),
+                    new \DateTimeZone('UTC')
+                );
+            } elseif (strtotime($birthday) === false) {
+                $birthday = DateTime::createFromFormat('Y-d-m', $birthday);
+            } else {
+                $birthday = new DateTime($birthday);
+            }
+        }
+
+        if (empty($birthday)) {
+            $birthday = false;
         }
 
         $this->birthday = $birthday;
@@ -271,8 +285,13 @@ public function getDeathday()
     public function setDeathday($deathday)
     {
         if (!$deathday instanceof DateTime && !empty($deathday)) {
-            // Is the format Y-m-d ?
-            if (strtotime($deathday) === false) {
+            if (ctype_digit($deathday) && strlen(4)) {
+                $deathday = DateTime::createFromFormat(
+                    'Y-m-d',
+                    sprintf('%d-01-01', $deathday),
+                    new \DateTimeZone('UTC')
+                );
+            } elseif (strtotime($deathday) === false) {
                 $deathday = DateTime::createFromFormat('Y-d-m', $deathday);
             } else {
                 $deathday = new DateTime($deathday);

test/Tmdb/Tests/Api/TestCase.php

@@ -21,7 +21,6 @@
 use Tmdb\Client;
 use Tmdb\Common\ParameterBag;
 use Tmdb\Tests\TestCase as Base;
-
 use Tmdb\Token\Session\GuestSessionToken;
 
 use function json_decode;

test/Tmdb/Tests/Model/PersonTest.php

@@ -14,7 +14,11 @@
 
 namespace Tmdb\Tests\Model;
 
+use Http\Mock\Client;
 use stdClass;
+use Tmdb\Common\ObjectHydrator;
+use Tmdb\Factory\PeopleFactory;
+use Tmdb\HttpClient\HttpClient;
 use Tmdb\Model\Common\GenericCollection;
 use Tmdb\Model\Person;
 
@@ -76,4 +80,21 @@ public function shouldAllowOverridingDefaultCollectionObjects()
             ]
         );
     }
+
+    /**
+     * @test
+     */
+    public function regressionIssue180()
+    {
+        $person = (new ObjectHydrator())->hydrate(new Person(), [
+            'birthday' => '1945',
+            'deathday' => '1946',
+        ]);
+
+        $actualBirthDate = $person->getBirthday()->format('Y-m-d');
+        $actualDeathDate = $person->getDeathday()->format('Y-m-d');
+
+        $this->assertEquals('1945-01-01', $actualBirthDate);
+        $this->assertEquals('1946-01-01', $actualDeathDate);
+    }
 }