Skip to content

Commit 97a33c8

Browse files
committed
Rename the find method, making sure it's not seen as an constructor.
1 parent 1355c0a commit 97a33c8

5 files changed

Lines changed: 6 additions & 6 deletions

File tree

examples/find/api/get.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
$token = new \Tmdb\ApiToken(TMDB_API_KEY);
1717
$client = new \Tmdb\Client($token);
1818

19-
$find = $client->getFindApi()->find('tt0120737', [
19+
$find = $client->getFindApi()->findBy('tt0120737', [
2020
'external_source' => 'imdb_id'
2121
]);
2222

examples/find/model/get.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717
$client = new \Tmdb\Client($token);
1818

1919
$repository = new \Tmdb\Repository\FindRepository($client);
20-
$find = $repository->find('tt0120737', ['external_source' => 'imdb_id']);
20+
$find = $repository->findBy('tt0120737', ['external_source' => 'imdb_id']);
2121

2222
var_dump($find);

lib/Tmdb/Api/Find.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class Find extends AbstractApi
3737
* @param array $headers
3838
* @return mixed
3939
*/
40-
public function find($id, array $parameters = [], array $headers = [])
40+
public function findBy($id, array $parameters = [], array $headers = [])
4141
{
4242
return $this->get(
4343
sprintf('find/%s', $id),

lib/Tmdb/Repository/FindRepository.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ class FindRepository extends AbstractRepository
3030
* @param array $headers
3131
* @return Find
3232
*/
33-
public function find($id, array $parameters = [], array $headers = [])
33+
public function findBy($id, array $parameters = [], array $headers = [])
3434
{
3535
return $this->getFactory()->create(
36-
$this->getApi()->find($id, $parameters, $headers)
36+
$this->getApi()->findBy($id, $parameters, $headers)
3737
);
3838
}
3939

test/Tmdb/Tests/Repository/FindRepositoryTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public function shouldGetMovieChanges()
2828
->with($this->getRequest('find/' . self::FIND_QUERY, []))
2929
;
3030

31-
$repository->find(self::FIND_QUERY);
31+
$repository->findBy(self::FIND_QUERY);
3232
}
3333

3434
protected function getApiClass()

0 commit comments

Comments
 (0)