Fix scrut bugs

Author: jcheron

.scrutinizer.yml

@@ -1,7 +1,7 @@
 filter:
     excluded_paths:
         - Ajax/JsUtils.php
-        - Ajax/php/yii/URI.php
+        - Ajax/php/
 checks:
     php:
         code_rating: true

Ajax/common/Widget.php

@@ -36,7 +36,7 @@ abstract class Widget extends HtmlDoubleElement {
 	 */
 	protected $_toolbar;
 	/**
-	 * @var PositionInTable
+	 * @var string
 	 */
 	protected $_toolbarPosition;
 
@@ -73,7 +73,7 @@ protected function _init($instanceViewer,$contentKey,$content,$edition){
 
 	/**
 	 * @param int|string $fieldName
-	 * @return int|string
+	 * @return int|string|boolean
 	 */
 	protected function _getIndex($fieldName){
 		$index=$fieldName;
@@ -250,7 +250,7 @@ public function addInToolbar($element,$callback=NULL){
 	 */
 	public function addItemInToolbar($caption,$icon=NULL,$callback=NULL){
 		$result=$this->addInToolbar($caption,$callback);
-		if(isset($icon))
+		if(isset($icon) && method_exists($result, "addIcon"))
 			$result->addIcon($icon);
 		return $result;
 	}
@@ -274,7 +274,7 @@ public function addItemsInToolbar(array $items,$callback=NULL){
 	}
 
 	/**
-	 * @param string $value
+	 * @param mixed $value
 	 * @param array $items
 	 * @param callable $callback function($element)
 	 * @return \Ajax\common\html\HtmlDoubleElement
@@ -399,11 +399,10 @@ public function getForm() {
 	}
 
 	public function run(JsUtils $js){
-		$result=parent::run($js);
+		parent::run($js);
 		if(isset($this->_form)){
-			$result=$this->runForm($js);
+			$this->runForm($js);
 		}
-		return $result;
 	}
 
 	protected function runForm(JsUtils $js){

Ajax/semantic/html/collections/HtmlBreadcrumb.php

@@ -36,7 +36,7 @@ class HtmlBreadcrumb extends HtmlSemNavElement {
 
 	/**
 	 *
-	 * @var object<Closure> the function who generates the href elements. default : function($e){return $e->getContent()}
+	 * @var callable the function who generates the href elements. default : function($e){return $e->getContent()}
 	 */
 	protected $_hrefFunction;
 
@@ -91,17 +91,18 @@ public function setActive($index=null) {
 	}
 
 	/**
-	 * Add new elements in breadcrumbs corresponding to request dispatcher : controllerName, actionName, parameters
+	 * Adds new elements in breadcrumbs corresponding to request dispatcher : controllerName, actionName, parameters
 	 * @param JsUtils $js
 	 * @param object $dispatcher the request dispatcher
-	 * @return \Ajax\bootstrap\html\HtmlBreadcrumbs
+	 * @return HtmlBreadcrumb
 	 */
 	public function fromDispatcher(JsUtils $js,$dispatcher, $startIndex=0) {
+		$this->startIndex=$startIndex;
 		return $this->addItems($js->fromDispatcher($dispatcher));
 	}
 
 	/**
-	 * Return the url of the element at $index or the breadcrumbs url if $index is ommited
+	 * Returns the url of the element at $index or the breadcrumbs url if $index is ommited
 	 * @param int $index
 	 * @param string $separator
 	 * @return string
@@ -123,7 +124,7 @@ public function getHref($index=null, $separator="/") {
 	 * sets the function who generates the href elements.
 	 * default : function($element){return $element->getContent()}
 	 * @param callable $_hrefFunction
-	 * @return \Ajax\bootstrap\html\HtmlBreadcrumbs
+	 * @return HtmlBreadcrumb
 	 */
 	public function setHrefFunction($_hrefFunction) {
 		$this->_hrefFunction=$_hrefFunction;