Merge pull request php-vcr#412 from lstrojny/fix-stream-handler-set-option

Fix stream handler set option

Author: higidi

src/VCR/Util/StreamProcessor.php

@@ -493,14 +493,14 @@ public function stream_lock(int $operation): bool
      *
      * @codeCoverageIgnore
      *
-     * @param int $option one of STREAM_OPTION_BLOCKING, STREAM_OPTION_READ_TIMEOUT, STREAM_OPTION_WRITE_BUFFER
-     * @param int $arg1   depending on option
-     * @param int $arg2   depending on option
+     * @param int      $option one of STREAM_OPTION_BLOCKING, STREAM_OPTION_READ_TIMEOUT, STREAM_OPTION_WRITE_BUFFER
+     * @param int      $arg1   depending on option
+     * @param int|null $arg2   depending on option
      *
      * @return bool Returns TRUE on success or FALSE on failure. If option is not implemented,
      *              FALSE should be returned.
      */
-    public function stream_set_option(int $option, int $arg1, int $arg2): bool
+    public function stream_set_option(int $option, int $arg1, ?int $arg2 = null): bool
     {
         if (false === $this->resource) {
             return false;

tests/Unit/Util/StreamProcessorTest.php

@@ -27,14 +27,32 @@ public function testFlockWithFilePutContents(): void
         $this->assertEquals(\strlen($testData), $res);
     }
 
+    public function testSetStreamOptions(): void
+    {
+        $processor = new StreamProcessor();
+        $processor->intercept();
+
+        $handle = fopen('tests/fixtures/file_put_contents', 'w');
+
+        self::assertTrue(stream_set_blocking($handle, true));
+        self::assertFalse(stream_set_timeout($handle, 10));
+        self::assertFalse(stream_set_timeout($handle, 5, 2));
+        self::assertSame(-1, stream_set_write_buffer($handle, 0));
+        self::assertSame(0, stream_set_read_buffer($handle, 0));
+
+        fclose($handle);
+
+        $processor->restore();
+    }
+
     /**
      * @dataProvider streamOpenAppendFilterProvider
      */
     public function testStreamOpenShouldAppendFilters(bool $expected, int $option, ?bool $shouldProcess = null): void
     {
         $mock = $this->getMockBuilder('VCR\Util\StreamProcessor')
             ->disableOriginalConstructor()
-            ->setMethods(['intercept', 'restore', 'appendFiltersToStream', 'shouldProcess'])
+            ->onlyMethods(['intercept', 'restore', 'appendFiltersToStream', 'shouldProcess'])
             ->getMock();
 
         if (null !== $shouldProcess) {
@@ -109,8 +127,22 @@ public function testUrlStatSuccessfully(): void
     public function testUrlStatFileNotFound(): void
     {
         $processor = new StreamProcessor();
-        $this->expectWarning();
-        $processor->url_stat('file_not_found', 0);
+
+        set_error_handler(static function (
+            int $errno,
+            string $errstr,
+            string $errfile = '',
+            int $errline = 0
+        ): void {
+            throw new \ErrorException($errstr, 0, $errno, $errfile, $errline);
+        }, \E_WARNING);
+
+        try {
+            $this->expectException(\ErrorException::class);
+            $processor->url_stat('file_not_found', 0);
+        } finally {
+            restore_error_handler();
+        }
     }
 
     /**
@@ -195,7 +227,7 @@ protected function getStreamProcessorMock()
     {
         return $this->getMockBuilder(StreamProcessor::class)
             ->disableOriginalConstructor()
-            ->setMethods(['intercept', 'restore'])
+            ->onlyMethods(['intercept', 'restore'])
             ->getMock();
     }
 }