phpstan-src/tests/PHPStan/Analyser/nsrt/pr-5379.php at 957c096837b0bffb495a2acfdf5a858eb85a4b1f · phpstan/phpstan-src · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
<?php

declare(strict_types=1);

namespace PR5379;

use ArrayAccess;

use function PHPStan\Testing\assertType;

class AggregationParser
{
	/**
	 * @param array<string, mixed> $aggregation
	 */
	private function parseAggregation(array $aggregation)
	{
		$type = $aggregation['type'] ?? null;
		if (!\is_string($type) || empty($type) || is_numeric($type)) {
			return null;
		}

		if (empty($aggregation['field']) && $type !== 'filter') {
			return null;
		}

		$field = '';
		if ($type !== 'filter') {
			$field = self::buildFieldName();
		}

		assertType('non-falsy-string', $type);
	}

	private static function buildFieldName(): string
	{
		return 'field';
	}
}

class AggregationParser2
{
	private function parseAggregation(string $aggregation, string $type)
	{
		if (empty($aggregation[1]) && $type !== 'filter') {
			return null;
		}
		assertType('string', $type);

		if ($type !== 'filter') {
			assertType('string', $type);
		}

		assertType('string', $type);
	}

	private function parseAggregation2(ArrayAccess $aggregation, string $type)
	{
		if (empty($aggregation['foo']) && $type !== 'filter') {
			return null;
		}
		assertType('string', $type);

		if ($type !== 'filter') {
			assertType('string', $type);
		}

		assertType('string', $type);
	}
}