InheritsCheck: process @provides recursively

Author: mgorny

NEWS.rst

@@ -8,6 +8,8 @@ pkgcheck 0.10.6 (2021-??-??)
 
 - add a check for calling EXPORT_FUNCTIONS before further inherits.
 
+- InheritsCheck: process @PROVIDES recursively.
+
 ----------------------------
 pkgcheck 0.10.5 (2021-08-16)
 ----------------------------

requirements/install.txt

@@ -4,4 +4,4 @@ lxml
 pathspec
 tree-sitter~=0.19.0
 snakeoil~=0.9.6
-pkgcore~=0.12.3
+pkgcore~=0.12.5

requirements/pyproject.toml

@@ -7,6 +7,6 @@ requires = [
 	"pathspec",
 	"tree-sitter~=0.19.0",
 	"snakeoil~=0.9.6",
-	"pkgcore~=0.12.3",
+	"pkgcore~=0.12.5",
 ]
 build-backend = "setuptools.build_meta"

src/pkgcheck/addons/eclass.py

@@ -49,7 +49,7 @@ class EclassAddon(caches.CachedAddon):
     """Eclass support for various checks."""
 
     # cache registry
-    cache = caches.CacheData(type='eclass', file='eclass.pickle', version=2)
+    cache = caches.CacheData(type='eclass', file='eclass.pickle', version=3)
 
     def __init__(self, *args):
         super().__init__(*args)
@@ -115,7 +115,7 @@ def update_cache(self, force=False):
                         except (KeyError, AttributeError):
                             try:
                                 progress(f'{repo} -- updating eclass cache: {name:<{padding}}')
-                                eclasses[name] = EclassDoc(path, sourced=True)
+                                eclasses[name] = EclassDoc(path, sourced=True, repo=repo)
                                 cache_eclasses = True
                             except IOError:
                                 continue

src/pkgcheck/checks/codingstyle.py

@@ -676,8 +676,7 @@ def feed(self, pkg):
                     used[eclass].append((lineno + 1, name, name))
 
         # allowed indirect inherits
-        indirect_allowed = set().union(*(
-            self.eclass_cache[x].indirect_eclasses for x in pkg.inherit))
+        indirect_allowed = set().union(*(self.eclass_cache[x].provides for x in pkg.inherit))
         # missing inherits
         missing = used.keys() - pkg.inherit - indirect_allowed - conditional
 

testdata/repos/eclass/InheritsCheck/IndirectInherits/IndirectInherits-1.ebuild

@@ -0,0 +1,13 @@
+EAPI=7
+
+inherit deep-provided-inherit
+
+DESCRIPTION="Ebuild relying on indirect inherit"
+HOMEPAGE="https://github.com/pkgcore/pkgcheck"
+SLOT="0"
+LICENSE="BSD"
+
+src_prepare() {
+	inherit_public_func
+	deep-provided-inherit_public_func
+}

testdata/repos/eclass/eclass/deep-provided-inherit.eclass

@@ -0,0 +1,14 @@
+# @ECLASS: deep-provided-inherit.eclass
+# @MAINTAINER:
+# Random Person <maintainer@random.email>
+# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6 7
+# @PROVIDES: provided-inherit
+# @BLURB: Stub eclass for testing InheritsCheck.
+
+inherit provided-inherit
+
+
+# @FUNCTION: deep-provided-inherit_public_func
+# @DESCRIPTION:
+# Public stub function.
+deep-provided-inherit_public_func() { :; }

testdata/repos/eclass/eclass/provided-inherit.eclass

@@ -0,0 +1,8 @@
+# @ECLASS: provided-inherit.eclass
+# @MAINTAINER:
+# Random Person <maintainer@random.email>
+# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6 7
+# @PROVIDES: inherit
+# @BLURB: Stub eclass for testing InheritsCheck.
+
+inherit inherit