codingstyle: collapse _CommandResult desc building

Author: radhermit

src/pkgcheck/checks/codingstyle.py

@@ -96,18 +96,22 @@ def __init__(self, command, line, lineno, **kwargs):
         self.line = line
         self.lineno = lineno
 
-
-class PortageInternals(_CommandResult, base.Error):
-    """Ebuild uses a function or variable internal to portage."""
+    @property
+    def usage_desc(self):
+        return f'{self.command!r}'
 
     @property
     def desc(self):
-        s = f'{self.command!r}, used on line {self.lineno}'
+        s = f'{self.usage_desc}, used on line {self.lineno}'
         if self.line != self.command:
             s +=  f': {self.line!r}'
         return s
 
 
+class PortageInternals(_CommandResult, base.Error):
+    """Ebuild uses a function or variable internal to portage."""
+
+
 class _EapiCommandResult(_CommandResult):
     """Generic EAPI command result."""
 
@@ -116,11 +120,8 @@ def __init__(self, *args, eapi, **kwargs):
         self.eapi = eapi
 
     @property
-    def desc(self):
-        s = f'{self.command!r} {self._status} in EAPI {self.eapi}, used on line {self.lineno}'
-        if self.line != self.command:
-            s +=  f': {self.line!r}'
-        return s
+    def usage_desc(self):
+        return f'{self.command!r} {self._status} in EAPI {self.eapi}'
 
 
 class DeprecatedEapiCommand(_EapiCommandResult, base.Warning):