config: default to external repos for add_repo()

Author: radhermit

examples/eapi-usage

@@ -27,7 +27,7 @@ def main():
     try:
         config.load()
         if os.path.sep in args.repo:
-            repo = config.add_repo(args.repo, external=True)
+            repo = config.add_repo(args.repo)
         else:
             repo = config.repos[args.repo]
     except PkgcraftError as e:

examples/leaf-pkgs

@@ -27,7 +27,7 @@ def main():
     try:
         config.load()
         if os.path.sep in args.repo:
-            repo = config.add_repo(args.repo, external=True)
+            repo = config.add_repo(args.repo)
         else:
             repo = config.repos[args.repo]
     except PkgcraftError as e:

examples/query

@@ -67,7 +67,7 @@ def main():
     try:
         if args.repos:
             for path in args.repos:
-                config.add_repo(path, external=True)
+                config.add_repo(path)
         else:
             config.load()
     except PkgcraftError as e:

examples/revdeps

@@ -33,7 +33,7 @@ def main():
     try:
         if args.repos:
             for path in args.repos:
-                config.add_repo(path, external=True)
+                config.add_repo(path)
         else:
             config.load()
     except PkgcraftError as e:

src/pkgcraft/config.pyx

@@ -46,7 +46,7 @@ cdef class Config:
 
         return Repo.from_ptr(ptr, False)
 
-    def add_repo(self, repo not None, id=None, priority=0, external=False):
+    def add_repo(self, repo not None, id=None, priority=0, external=True):
         """Add a repo via its file path or from a Repo object and return the Repo object."""
         if isinstance(repo, (str, os.PathLike)):
             path = str(repo)

tests/conftest.py

@@ -34,5 +34,5 @@ def testdata_config():
     """All repo test data loaded into a Config object."""
     config = Config()
     for path in sorted(glob.glob(f"{DATADIR}/repos/*")):
-        config.add_repo(path, id=os.path.basename(path))
+        config.add_repo(path, id=os.path.basename(path), external=False)
     return config