repo: drop repo id matching for RepoSet __getitem__() support

All string-based keys now are treated as pkg restrictions.

Author: radhermit

src/pkgcraft/repo/set.pyx

@@ -46,14 +46,8 @@ cdef class RepoSet:
         elif isinstance(key, slice):
             # create a new RepoSet for slices
             return self.__class__(*list(self.repos)[key])
-        elif isinstance(key, str):
-            # matching repo name for strings
-            matching_repos = (r for r in self.repos if r.id == key)
-            if repo := next(matching_repos, None):
-                return repo
-
-        # try to return the pkgs matching a restriction
-        if pkgs := list(self.iter(key)):
+        elif pkgs := list(self.iter(key)):
+            # try to return the pkgs matching a restriction
             if len(pkgs) > 1:
                 return pkgs
             return pkgs[0]

tests/repo/test_set.py

@@ -152,7 +152,6 @@ def test_getitem(self, make_fake_repo):
         s = self.cls(r1)
         assert s[:] == s
         assert s[0] == r1
-        assert s["r1"] == r1
         assert s["cat/pkg"] == pkg
         assert s["cat/pkg-1"] == pkg
         assert s[Cpv("cat/pkg-1")] == pkg
@@ -166,7 +165,6 @@ def test_getitem(self, make_fake_repo):
         s = self.cls(r1, r2)
         assert s[:] == s
         assert s[-1] == r2
-        assert s["r2"] == r2
         assert s["cat/pkg"] == [pkg, pkg1, pkg2]
         assert s["cat/pkg-1"] == [pkg, pkg1]
         assert s["=cat/pkg-1::r2"] == pkg1