dep: rename UseDep default field for consistency

Working around cython's apparent reserved keyword issues re-exporting
via a property.

Author: radhermit

src/pkgcraft/C.pxd

@@ -211,7 +211,7 @@ cdef extern from "pkgcraft.h":
     cdef struct UseDep:
         UseDepKind kind
         char *flag
-        UseDepDefault *missing
+        UseDepDefault *default_
         UseDepWrapper *dep
 
     # C-compatible wrapper for pkgcraft::dep::Dependency.

src/pkgcraft/dep/use_dep.pxd

@@ -5,7 +5,7 @@ cdef class UseDep:
     cdef C.UseDep *ptr
     cdef readonly object kind
     cdef readonly str flag
-    cdef readonly object missing
+    cdef object default_
     # cached fields
     cdef int _hash
 

src/pkgcraft/dep/use_dep.pyx

@@ -43,7 +43,7 @@ cdef class UseDep:
         'use'
         >>> u.kind == UseDepKind.DisabledConditional
         True
-        >>> u.missing is None
+        >>> u.default is None
         True
         >>> str(u)
         '!use?'
@@ -52,7 +52,7 @@ cdef class UseDep:
         'use'
         >>> u.kind == UseDepKind.Equal
         True
-        >>> u.missing == UseDepDefault.Enabled
+        >>> u.default == UseDepDefault.Enabled
         True
         >>> str(u)
         'use(+)='
@@ -71,10 +71,10 @@ cdef class UseDep:
 
         self.kind = UseDepKind(ptr.kind)
         self.flag = ptr.flag.decode()
-        if ptr.missing is NULL:
-            self.missing = None
+        if ptr.default_ is NULL:
+            self.default_ = None
         else:
-            self.missing = UseDepDefault(ptr.missing[0])
+            self.default_ = UseDepDefault(ptr.default_[0])
         self.ptr = ptr
 
     @staticmethod
@@ -84,12 +84,18 @@ cdef class UseDep:
         inst.ptr = <C.UseDep *>ptr
         inst.kind = UseDepKind(ptr.kind)
         inst.flag = ptr.flag.decode()
-        if ptr.missing is NULL:
-            inst.missing = None
+        if ptr.default_ is NULL:
+            inst.default_ = None
         else:
-            inst.missing = UseDepDefault(ptr.missing[0])
+            inst.default_ = UseDepDefault(ptr.default_[0])
         return inst
 
+    # Re-export the default field using its proper name, if exposed directly via
+    # an attribute the bindings fail to compile.
+    @property
+    def default(self):
+        return self.default_
+
     def __lt__(self, other):
         if isinstance(other, UseDep):
             return C.pkgcraft_use_dep_cmp(self.ptr, (<UseDep>other).ptr) == -1

tests/dep/test_use_dep.py

@@ -25,7 +25,9 @@ def test_creation(self):
                 use = UseDep(s)
                 assert use.kind == kind
                 assert use.flag == "u"
-                assert use.missing == default
+                assert use.default == default
+                # verify the internal field is hidden from native python
+                assert getattr(use, "default_", None) is None
                 assert str(use) == s
                 assert s in repr(use)