Skip to content

Commit 0d108a0

Browse files
committed
migrated from global scope
1 parent 2875931 commit 0d108a0

3 files changed

Lines changed: 16 additions & 9 deletions

File tree

OGParser/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ dependencies {
4848
//Architecture
4949
def lifecycle_version = '2.2.0'
5050

51-
implementation "androidx.lifecycle:lifecycle-extensions:${lifecycle_version}"
52-
implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:${lifecycle_version}"
51+
implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9'
52+
// implementation "androidx.lifecycle:lifecycle-extensions:${lifecycle_version}"
53+
// implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:${lifecycle_version}"
5354
}

OGParser/src/main/java/com/kedia/ogparser/OpenGraphParser.kt

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
package com.kedia.ogparser
22

3-
import kotlinx.coroutines.Dispatchers
4-
import kotlinx.coroutines.GlobalScope
5-
import kotlinx.coroutines.launch
6-
import kotlinx.coroutines.withContext
3+
import kotlinx.coroutines.*
74
import org.jsoup.Jsoup
5+
import kotlin.coroutines.CoroutineContext
86

97

108
class OpenGraphParser(
@@ -30,12 +28,20 @@ class OpenGraphParser(
3028

3129
fun parse(url: String) {
3230
this.url = url
31+
parseLink().parse()
32+
}
33+
34+
inner class parseLink : CoroutineScope {
35+
36+
private val job: Job = Job()
37+
override val coroutineContext: CoroutineContext
38+
get() = Dispatchers.Main + job
3339

34-
GlobalScope.launch(Dispatchers.Main) {
40+
41+
fun parse() = launch {
3542
val result = fetchContent()
3643
result?.let { listener.onPostResponse(it) }
3744
}
38-
3945
}
4046

4147
private suspend fun fetchContent() = withContext(Dispatchers.IO) {

app/src/main/java/com/kedia/opengraphpreview/MainActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class MainActivity : AppCompatActivity(), OpenGraphCallback {
1818
}
1919

2020
override fun onPostResponse(openGraphResult: OpenGraphResult) {
21-
Log.d("TAG!!!!", "onPostResponse: called $openGraphResult")
21+
Log.d("TAG!!!!", "${Thread.currentThread().name}onPostResponse: called $openGraphResult")
2222
}
2323

2424
override fun onError(error: String) {

0 commit comments

Comments
 (0)