build: add PHPStan static analysis at level 5

Add phpstan/phpstan ^2 at level 5 with a baseline of 13 errors (all
interface method gaps on ClientInterface and ConnectorInterface).
Globally ignore new.static (deliberate polymorphism pattern).

Add PHPStan step to GitHub Actions CI and a Makefile with lint/test
targets.

Fixes found by PHPStan:
- Project::systemInformation() return type missing false case
- RestoreOptions: redundant @return PHPDocs conflicting with native
  static return type
- LogItem: static:: to self:: for private method
- Tree::getBlob(): always-true instanceof and unreachable code
- Resolver: always-true explode() assignment in condition
- ResourceWithReferences: always-true getResponse() check
- Result::getEntity(): redundant isset() on initialized property
- Subscription::create(): new self() vs new static() return mismatch
- EnvironmentTest: incorrect @var annotation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: pjcdawkins

.github/workflows/ci.yml

@@ -26,5 +26,11 @@ jobs:
             - name: Install dependencies
               run: composer install --no-progress --no-suggest --no-interaction
 
+            - name: Run ECS
+              run: ./vendor/bin/ecs check
+
+            - name: Run PHPStan
+              run: ./vendor/bin/phpstan analyse
+
             - name: Run PHPUnit tests
               run: ./vendor/bin/phpunit

Makefile

@@ -0,0 +1,12 @@
+.PHONY: lint lint-ecs lint-phpstan test
+
+lint: lint-ecs lint-phpstan
+
+lint-ecs:
+	./vendor/bin/ecs check
+
+lint-phpstan:
+	./vendor/bin/phpstan analyse
+
+test:
+	./vendor/bin/phpunit

composer.json

@@ -12,7 +12,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^11",
-        "symplify/easy-coding-standard": "^12.3"
+        "symplify/easy-coding-standard": "^12.3",
+        "phpstan/phpstan": "^2"
     },
     "autoload": {
         "psr-4": {

composer.lock

@@ -0,0 +1,61 @@
+parameters:
+	ignoreErrors:
+		-
+			message: '#^Call to an undefined method GuzzleHttp\\ClientInterface\:\:get\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: src/Model/Activity.php
+
+		-
+			message: '#^Call to an undefined method GuzzleHttp\\ClientInterface\:\:patch\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: src/Model/Organization/Address.php
+
+		-
+			message: '#^Call to an undefined method GuzzleHttp\\ClientInterface\:\:get\(\)\.$#'
+			identifier: method.notFound
+			count: 2
+			path: src/Model/Organization/Organization.php
+
+		-
+			message: '#^Call to an undefined method GuzzleHttp\\ClientInterface\:\:patch\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: src/Model/Organization/Organization.php
+
+		-
+			message: '#^Call to an undefined method GuzzleHttp\\ClientInterface\:\:patch\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: src/Model/Organization/Profile.php
+
+		-
+			message: '#^Call to an undefined method GuzzleHttp\\ClientInterface\:\:get\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: src/Model/Ref/Resolver.php
+
+		-
+			message: '#^Call to an undefined method GuzzleHttp\\ClientInterface\:\:get\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: src/Model/SetupOptions.php
+
+		-
+			message: '#^Call to an undefined method GuzzleHttp\\ClientInterface\:\:patch\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: src/Model/Team/Team.php
+
+		-
+			message: '#^Call to an undefined method GuzzleHttp\\ClientInterface\:\:patch\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: src/Model/UserAccess/ProjectUserAccess.php
+
+		-
+			message: '#^Call to an undefined method GuzzleHttp\\ClientInterface\:\:post\(\)\.$#'
+			identifier: method.notFound
+			count: 1
+			path: src/PlatformClient.php

phpstan-baseline.neon

@@ -0,0 +1,12 @@
+includes:
+	- phpstan-baseline.neon
+
+parameters:
+	level: 5
+	paths:
+		- src
+		- tests
+	ignoreErrors:
+		# Deliberate pattern: resource classes use new static() for polymorphism.
+		-
+			identifier: new.static

phpstan.neon

@@ -53,6 +53,16 @@ public function getClient(): ClientInterface;
      */
     public function setApiToken(string $token, string $type);
 
+    /**
+     * Get the connector configuration.
+     */
+    public function getConfig(): array;
+
+    /**
+     * Returns the access token saved in the session, if any.
+     */
+    public function getAccessToken(): ?string;
+
     /**
      * Get the configured API gateway URL (without trailing slash).
      */

src/Connection/ConnectorInterface.php

@@ -34,7 +34,7 @@ public function __toString()
      */
     public static function singleFromJson(string $str): self|false
     {
-        $data = static::decode($str);
+        $data = self::decode($str);
         if (isset($data['data']['timestamp'], $data['data']['message'])) {
             $id = isset($data['_id']) ? (string) $data['_id'] : '';
             return new static($data['data']['timestamp'], $data['data']['message'], $id);
@@ -43,7 +43,7 @@ public static function singleFromJson(string $str): self|false
     }
 
     /**
-     * @return static[]
+     * @return self[]
      *@deprecated use LogItem::multipleFromJsonStreamWithSeal() instead
      */
     public static function multipleFromJsonStream(string $str): array
@@ -77,7 +77,7 @@ public static function multipleFromJsonStreamWithSeal(string $str): array
             if ($line === '') {
                 continue;
             }
-            $data = static::decode($line);
+            $data = self::decode($line);
             if (is_array($data)) {
                 if (! empty($data['seal'])) {
                     $seal = true;

src/Model/ActivityLog/LogItem.php

@@ -1,9 +1,12 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Platformsh\Client\Model;
 
 /**
  * Represents environment autoscaling settings.
- *
  */
-class AutoscalingSettings extends ApiResourceBase {}
+class AutoscalingSettings extends ApiResourceBase
+{
+}

src/Model/AutoscalingSettings.php

@@ -16,45 +16,30 @@ class RestoreOptions
 
     private ?string $resourcesInit;
 
-    /**
-     * @return RestoreOptions
-     */
     public function setEnvironmentName(?string $environmentName): static
     {
         $this->environmentName = $environmentName;
         return $this;
     }
 
-    /**
-     * @return RestoreOptions
-     */
     public function setBranchFrom(?string $branchFrom): static
     {
         $this->branchFrom = $branchFrom;
         return $this;
     }
 
-    /**
-     * @return RestoreOptions
-     */
     public function setRestoreCode(?bool $restoreCode): static
     {
         $this->restoreCode = $restoreCode;
         return $this;
     }
 
-    /**
-     * @return RestoreOptions
-     */
     public function setRestoreResources(?bool $restoreResources): static
     {
         $this->restoreResources = $restoreResources;
         return $this;
     }
 
-    /**
-     * @return RestoreOptions
-     */
     public function setResourcesInit(?string $init): static
     {
         $this->resourcesInit = $init;