Skip to content

Commit d5f4789

Browse files
committed
update Jasmine test
1 parent a26650b commit d5f4789

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

draftlogs/7802_change.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
- Update `sendDataToCloud` modebar button to upload chart to Plotly Cloud [[#7802](https://github.com/plotly/plotly.js/pull/7802), [#7852](https://github.com/plotly/plotly.js/pull/7852)]
1+
- Update `sendDataToCloud` modebar button to upload chart to Plotly Cloud [[#7802](https://github.com/plotly/plotly.js/pull/7802), [#7852](https://github.com/plotly/plotly.js/pull/7852), [#7854](https://github.com/plotly/plotly.js/pull/7854)]
22
- NOTE: The Plotly Cloud endpoint for receiving charts is not yet functional, so this button won't complete the upload.

test/jasmine/tests/config_test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -585,8 +585,9 @@ describe('config argument', function() {
585585
expect(confirmBtn).not.toBe(null, 'confirm button should be shown');
586586
mouseEvent('click', 0, 0, {element: confirmBtn});
587587

588-
// Should open the provided URL's origin in a new tab
589-
expect(openSpy).toHaveBeenCalledWith('https://example.plotly.com/endpoint', '_blank');
588+
// Should open the provided URL's origin in a new tab,
589+
// adding the current page's origin as a query parameter
590+
expect(openSpy).toHaveBeenCalledWith('https://example.plotly.com/endpoint?origin=http%3A%2F%2Flocalhost%3A9876', '_blank');
590591
})
591592
.then(done, done.fail);
592593
});

0 commit comments

Comments
 (0)