validate partial ranges and set autorange true for invalid partial ranges

Author: archmoj

src/plots/cartesian/axis_defaults.js

@@ -97,11 +97,28 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, coerce,
     var range = coerce('range');
 
     var autorangeDflt = containerOut.getAutorangeDflt(range, options);
+    var autorange = coerce('autorange', autorangeDflt);
+    var autorangeTrue;
+
+    // validate range and set autorange true for invalid partial ranges
+    if(range && (
+        (range[0] === null && range[1] === null) ||
+        (range[0] !== null && (autorange === 'min' || autorange === 'max reversed')) ||
+        (range[1] !== null && (autorange === 'max' || autorange === 'min reversed'))
+    )) {
+        range = undefined;
+        delete containerOut.range;
+        containerOut.autorange = true;
+        autorangeTrue = true;
+    }
 
-    var autoRange = coerce('autorange', autorangeDflt);
-    if(autoRange) {
-        handleAutorangeOptionsDefaults(coerce, autoRange, range);
+    if(!autorangeTrue) {
+        autorangeDflt = containerOut.getAutorangeDflt(range, options);
+        autorange = coerce('autorange', autorangeDflt);
+    }
 
+    if(autorange) {
+        handleAutorangeOptionsDefaults(coerce, autorange, range);
         if(axType === 'linear' || axType === '-') coerce('rangemode');
     }
 

src/plots/polar/layout_defaults.js

@@ -82,11 +82,29 @@ function handleDefaults(contIn, contOut, coerce, opts) {
                 var range = coerceAxis('range');
 
                 var autorangeDflt = axOut.getAutorangeDflt(range);
+                var autorange = coerceAxis('autorange', autorangeDflt);
+                var autorangeTrue;
+
+                // validate range and set autorange true for invalid partial ranges
+                if(range && (
+                    (range[0] === null && range[1] === null) ||
+                    (range[0] !== null && (autorange === 'min' || autorange === 'max reversed')) ||
+                    (range[1] !== null && (autorange === 'max' || autorange === 'min reversed'))
+                )) {
+                    range = undefined;
+                    delete axOut.range;
+                    axOut.autorange = true;
+                    autorangeTrue = true;
+                }
+
+                if(!autorangeTrue) {
+                    autorangeDflt = axOut.getAutorangeDflt(range);
+                    autorange = coerceAxis('autorange', autorangeDflt);
+                }
 
-                var autoRange = coerceAxis('autorange', autorangeDflt);
-                axIn.autorange = autoRange;
-                if(autoRange) {
-                    handleAutorangeOptionsDefaults(coerceAxis, autoRange, range);
+                axIn.autorange = autorange;
+                if(autorange) {
+                    handleAutorangeOptionsDefaults(coerceAxis, autorange, range);
 
                     if(axType === 'linear' || axType === '-') coerceAxis('rangemode');
                     if(axOut.isReversed()) axOut._m = -1;

test/jasmine/tests/axes_test.js

@@ -719,12 +719,17 @@ describe('Test axes', function() {
             layoutIn = {
                 xaxis: { range: 'not-gonna-work' },
                 xaxis2: { range: [1] },
+                xaxis3: { range: [null, null] },
                 yaxis: { range: ['a', 2] },
                 yaxis2: { range: [1, 'b'] },
-                yaxis3: { range: [undefined, {}] }
+                yaxis3: { range: [undefined, {}] },
+                yaxis4: { range: [1, null], autorange: 'min' }, // second range is null not first
+                yaxis5: { range: [null, 2], autorange: 'max' }, // first range is null not second
+                yaxis6: { range: [1, null], autorange: 'max reversed' }, // second range is null not first
+                yaxis7: { range: [null, 2], autorange: 'min reversed' }, // first range is null not second
             };
-            layoutOut._subplots.cartesian.push('x2y2', 'xy3');
-            layoutOut._subplots.yaxis.push('x2', 'y2', 'y3');
+            layoutOut._subplots.cartesian.push('x2y2', 'xy3', 'x3y4', 'x3y5', 'x3y6', 'x3y7');
+            layoutOut._subplots.yaxis.push('x2', 'x3', 'y2', 'y3', 'y4', 'y5', 'y6', 'y7');
 
             supplyLayoutDefaults(layoutIn, layoutOut, fullData);