add dedicated right

Author: stonebuzz

ajax/agent.php

@@ -36,12 +36,8 @@
 Html::header_nocache();
 
 Session::checkLoginUser();
-
 Session::checkRight("inventory", READ);
-
-$computer = new Computer();
-$computer->check($_POST['computers_id'], UPDATE);
-
+Session::checkRight("database_inventory", PluginDatabaseinventoryProfile::RUN_DATABSE_INVENTORY);
 
 if (isset($_POST['action']) && isset($_POST['id'])) {
     $agent = new Agent();

inc/inventoryaction.class.php

@@ -34,6 +34,7 @@ class PluginDatabaseinventoryInventoryAction extends CommonDBTM
 {
     public const MA_PARTIAL        = 'partial_database_inventory';
     private const ENDPOINT_PARTIAL = 'now?';
+    public static $rightname = 'database_inventory_run_inventory';
 
     public static function showMassiveActionsSubForm(MassiveAction $ma)
     {
@@ -168,6 +169,10 @@ public static function postItemForm($item)
             return;
         }
 
+        if (!Session::checkRight("database_inventory", PluginDatabaseinventoryProfile::RUN_DATABSE_INVENTORY)) {
+            return;
+        }
+
         if ($item::getType() == Computer::getType()) {
             if ($agent = self::findAgent($item)) {
                 $out = '<div class="mb-3 col-12 col-sm-6">';

inc/profile.class.php

@@ -32,6 +32,8 @@ class PluginDatabaseinventoryProfile extends Profile
 {
     public static $rightname = 'profile';
 
+    const RUN_DATABSE_INVENTORY = 256;
+
     public static function getTypeName($nb = 0)
     {
         return __('Database Inventory', 'databaseinventory');
@@ -41,15 +43,31 @@ private static function getAllRights($all = false)
     {
         $rights = [
             [
-                'itemtype' => PluginDatabaseinventoryDatabaseParam::getType(),
-                'label'    => PluginDatabaseinventoryProfile::getTypeName(),
-                'field'    => 'database_inventory',
+                'itemtype'  => PluginDatabaseinventoryDatabaseParam::getType(),
+                'label'     => PluginDatabaseinventoryProfile::getTypeName(),
+                'field'     => 'database_inventory',
+                'rights'    => [
+                    CREATE  => __('Create'),
+                    READ    => __('Read'),
+                    UPDATE  => __('Update'),
+                    PURGE   => ['short' => __('Purge'),
+                        'long'  => _x('button', 'Delete permanently'),
+                    ],
+                    self::RUN_DATABSE_INVENTORY => __("Run database inventory", "databaseinventory"),
+                ],
             ],
         ];
 
         return $rights;
     }
 
+    function getRights($interface = 'central')
+    {
+        $rights = parent::getRights();
+        $rights[self::RUN_DATABSE_INVENTORY] = __("Run database inventory", "databaseinventory");
+        return $rights;
+    }
+
     public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
     {
         if ($item->getType() == 'Profile') {
@@ -96,10 +114,10 @@ private static function showForProfile($profiles_id = 0)
     public static function install(Migration $migration)
     {
         // Add right for administrators
-        $migration->addRight('database_inventory', PURGE + CREATE + UPDATE + READ, ['config' => UPDATE]);
+        $migration->addRight('database_inventory', PURGE + CREATE + UPDATE + READ + self::RUN_DATABSE_INVENTORY, ['config' => UPDATE]);
 
         // Add right to the current session
-        $_SESSION['glpiactiveprofile']['database_inventory'] = PURGE + CREATE + UPDATE + READ;
+        $_SESSION['glpiactiveprofile']['database_inventory'] = PURGE + CREATE + UPDATE + READ + self::RUN_DATABSE_INVENTORY;
 
         return true;
     }