Add tasks visibility option (#449)

* Add tasks visibility option

* Add in config template

* Update changelog

* Fix lint

* FIx tests

* FIx tests

* FIx lints

Author: Lainow

CHANGELOG.md

@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Fixed routing issue caused by incorrect trailing slash
 - Fix to rule execution based on group deletion
 
+### Added
+
+- Add task visibility option (`task_private`)
+
 ## [2.9.19] - 2026-27-01
 
 ### Fixed

hook.php

@@ -85,12 +85,13 @@ function plugin_escalade_install()
          `use_filter_assign_group`                 INT NOT NULL,
          `ticket_last_status`                      INT NOT NULL,
          `remove_requester`                        INT NOT NULL,
+         `task_private`                            INT NOT NULL,
          PRIMARY KEY (`id`)
       ) ENGINE=InnoDB DEFAULT CHARSET={$default_charset} COLLATE={$default_collation} ROW_FORMAT=DYNAMIC;";
         $DB->doQuery($query);
 
         $query = "INSERT INTO glpi_plugin_escalade_configs
-      VALUES (NULL, 1, 1, 1, 1, 1, 0, 0, 1, 1, 1, 0, 0, 0, 1, 1, 0, 1, 1, 0, 1, 0, '" . Ticket::WAITING . "',0)";
+      VALUES (NULL, 1, 1, 1, 1, 1, 0, 0, 1, 1, 1, 0, 0, 0, 1, 1, 0, 1, 1, 0, 1, 0, '" . Ticket::WAITING . "',0, 1)";
         $DB->doQuery($query);
     }
 
@@ -390,6 +391,18 @@ function plugin_escalade_install()
         $migration->migrationOneTable('glpi_plugin_escalade_users');
     }
 
+    //Update to 2.10.2
+    // add new fields
+    if (!$DB->fieldExists('glpi_plugin_escalade_configs', 'task_private')) {
+        $migration->addField(
+            'glpi_plugin_escalade_configs',
+            'task_private',
+            'integer',
+            ['after' => 'remove_requester'],
+        );
+        $migration->migrationOneTable('glpi_plugin_escalade_configs');
+    }
+
     return true;
 }
 

inc/ticket.class.php

@@ -563,7 +563,7 @@ function (array $actor) use ($groups_id, &$seen_new_group): bool {
         $task_content = '<p><i>' . sprintf(__s('Escalation to the group %s.', 'escalade'), $group->getName()) . '</i></p><hr />' . $comment;
         PluginEscaladeTaskmanager::setTicketTask([
             'tickets_id' => $tickets_id,
-            'is_private' => true,
+            'is_private' => $_SESSION['glpi_plugins']['escalade']['config']['task_private'],
             'state'      => Planning::INFO,
             'content'    => $task_content,
         ]);

templates/config.html.twig

@@ -194,6 +194,13 @@
                     field_options
                 ) }}
 
+                {{ fields.sliderField(
+                    'task_private',
+                    config["task_private"],
+                    __("Escalation task is private ?", "escalade"),
+                    field_options
+                ) }}
+
                 {{ fields.dropdownArrayField(
                     'ticket_last_status',
                     config["ticket_last_status"],

tests/EscaladeTestCase.php

@@ -113,6 +113,7 @@ public function initConfig(array $conf = [])
             'cloneandlink_ticket' => 0,
             'close_linkedtickets' => 0,
             'reassign_group_from_cat' => 0,
+            'task_private' => 1,
         ];
 
         // Update escalade config in database if provided

tests/Units/TaskMessageTest.php

@@ -276,4 +276,65 @@ public function testTaskGroupEscalation(array $conf)
             }
         }
     }
+
+    public static function taskPrivateProvider(): iterable
+    {
+        yield [
+            'task_private' => 0,
+            'expected_is_private' => 0,
+        ];
+
+        yield [
+            'task_private' => 1,
+            'expected_is_private' => 1,
+        ];
+    }
+
+    #[DataProvider('taskPrivateProvider')]
+    public function testTaskPrivateFlagOnEscalationTask(int $task_private, int $expected_is_private): void
+    {
+        $this->initConfig([
+            'task_history' => 1,
+            'task_private' => $task_private,
+        ]);
+
+        $ticket = $this->createItem('Ticket', [
+            'name' => 'Task private escalation test',
+            'content' => '',
+            'entities_id' => 0,
+        ]);
+
+        $this->createItem('Group', [
+            'name' => 'Task private group',
+            'entities_id' => 0,
+        ]);
+
+        $group2 = $this->createItem('Group', [
+            'name' => 'Task private group 2',
+            'entities_id' => 0,
+        ]);
+
+        $this->updateItem(
+            Ticket::class,
+            $ticket->getID(),
+            [
+                '_actors' => [
+                    'assign' => [
+                        [
+                            'items_id' => $group2->getID(),
+                            'itemtype' => 'Group',
+                        ],
+                    ],
+                ],
+            ],
+        );
+
+        $ticket_task = new TicketTask();
+        $ticket_tasks = $ticket_task->find(['tickets_id' => $ticket->getID()]);
+
+        $this->assertCount(1, $ticket_tasks);
+
+        $last_task = end($ticket_tasks);
+        $this->assertSame($expected_is_private, (int) $last_task['is_private']);
+    }
 }