Fix(build): clean front files (#1019)

Author: stonebuzz

front/commondropdown.form.php

@@ -1,5 +1,7 @@
 <?php
 
+use Glpi\DBAL\QueryParam;
+
 class %%CLASSNAME%% extends PluginFieldsAbstractContainerInstance
 {
    static $rightname = '%%ITEMTYPE_RIGHT%%';
@@ -51,7 +53,7 @@ class %%CLASSNAME%% extends PluginFieldsAbstractContainerInstance
       * This block ensures that the 'entities_id' field is created and populated if it
       * associated item type requires entity assignment
       */
-      if (getItemForItemtype('%%ITEMTYPE%%')->isEntityAssign() && !$DB->fieldExists($table, 'entities_id')) {
+      if (getItemForItemtype(%%ITEMTYPE%%::class)->isEntityAssign() && !$DB->fieldExists($table, 'entities_id')) {
          $migration->addField($table, 'entities_id', 'fkey', ['after' => 'plugin_fields_containers_id']);
          $migration->addKey($table, 'entities_id');
          $migration->executeMigration();
@@ -107,7 +109,7 @@ class %%CLASSNAME%% extends PluginFieldsAbstractContainerInstance
       * associated item type requires recursive assignment
       */
       if (
-         getItemForItemtype('%%ITEMTYPE%%')->maybeRecursive()
+         getItemForItemtype(%%ITEMTYPE%%::class)->maybeRecursive()
          && !$DB->fieldExists($table, 'is_recursive')
          && $DB->fieldExists($table, 'entities_id')) {
          $migration->addField($table, 'is_recursive', 'bool', ['after'  => 'entities_id']);

front/commondropdown.php

@@ -59,9 +59,7 @@ class %%CLASSNAME%% extends CommonTreeDropdown {
     * @param $full path or relative one (true by default)
    **/
    static function getTabsURL($full=true) {
-      $url = Toolbox::getItemTypeTabsURL('PluginFieldsCommonDropdown', $full);
-      $plug = isPluginItemType(get_called_class());
-      $url .= '?ddtype=' . strtolower($plug['class']);
+      $url = Toolbox::getItemTypeTabsURL(get_called_class(), $full);
       return $url;
    }
 
@@ -71,45 +69,7 @@ class %%CLASSNAME%% extends CommonTreeDropdown {
     * @param $full path or relative one (true by default)
    **/
    static function getSearchURL($full=true) {
-      $url = Toolbox::getItemTypeSearchURL('PluginFieldsCommonDropdown', $full);
-      $plug = isPluginItemType(get_called_class());
-      $url .= '?ddtype=' . strtolower($plug['class']);
+      $url = Toolbox::getItemTypeSearchURL(get_called_class(), $full);
       return $url;
    }
-
-   /**
-    * Get the form page URL for the current class
-    *
-    * @param $full path or relative one (true by default)
-   **/
-   static function getFormURL($full=true) {
-      $url = Toolbox::getItemTypeFormURL('PluginFieldsCommonDropdown', $full);
-      $plug = isPluginItemType(get_called_class());
-      $url .= '?ddtype=' . strtolower($plug['class']);
-      return $url;
-   }
-
-   /**
-    * Get the form page URL for the current class and point to a specific ID
-    *
-    * @param $id      (default 0)
-    * @param $full    path or relative one (true by default)
-    *
-    * @since version 0.90
-   **/
-   static function getFormURLWithID($id=0, $full=true) {
-
-      $link     = self::getFormURL($full);
-      $link    .= '&id=' . $id;
-      return $link;
-   }
-
-   /**
-    * Get default values to search engine to override
-   **/
-   static function getDefaultSearchRequest() {
-      $plug = isPluginItemType(get_called_class());
-      $search = ['addhidden' => ['ddtype' => strtolower($plug['class'])]];
-      return $search;
-   }
 }