Fix phpstan (#522)

* Fix phpstan

* fix

* fix

Author: Rom1-B

inc/notificationtargetorder.class.php

@@ -98,7 +98,7 @@ public function addDataForTemplate($event, $options = [])
                     $this->data[$tag] = $values['label'];
                 }
             }
-        } else {
+        } elseif ($this->obj instanceof CommonDBTM) {
             $this->data['##lang.ordervalidation.title##']     = $events[$event];
 
             $this->data['##lang.ordervalidation.entity##']    = __s("Entity");
@@ -503,22 +503,40 @@ public function addSpecificTargets($data, $options)
                 $this->addUserByField("users_id_delivery");
                 break;
             case self::AUTHOR_GROUP:
-                $this->addForGroup(0, $this->obj->fields['groups_id']);
+                if ($this->obj instanceof CommonDBTM) {
+                    $this->addForGroup(0, $this->obj->fields['groups_id']);
+                }
+
                 break;
             case self::DELIVERY_GROUP:
-                $this->addForGroup(0, $this->obj->fields['groups_id_delivery']);
+                if ($this->obj instanceof CommonDBTM) {
+                    $this->addForGroup(0, $this->obj->fields['groups_id_delivery']);
+                }
+
                 break;
             case self::SUPERVISOR_AUTHOR_GROUP:
-                $this->addForGroup(1, $this->obj->fields['groups_id']);
+                if ($this->obj instanceof CommonDBTM) {
+                    $this->addForGroup(1, $this->obj->fields['groups_id']);
+                }
+
                 break;
             case self::SUPERVISOR_DELIVERY_GROUP:
-                $this->addForGroup(1, $this->obj->fields['groups_id_delivery']);
+                if ($this->obj instanceof CommonDBTM) {
+                    $this->addForGroup(1, $this->obj->fields['groups_id_delivery']);
+                }
+
                 break;
             case self::SUPPLIER:
-                $this->addAddressesByType("suppliers", $this->obj->fields['id']);
+                if ($this->obj instanceof CommonDBTM) {
+                    $this->addAddressesByType("suppliers", $this->obj->fields['id']);
+                }
+
                 break;
             case self::CONTACT:
-                $this->addAddressesByType("contacts", $this->obj->fields['id']);
+                if ($this->obj instanceof CommonDBTM) {
+                    $this->addAddressesByType("contacts", $this->obj->fields['id']);
+                }
+
                 break;
         }
     }

inc/order.class.php

@@ -780,12 +780,12 @@ public function post_updateItem($history = true)
             $infocom = new Infocom();
             $query = [
                 'SELECT' => [
-                    `items_id`,
-                    `itemtype`,
+                    'items_id',
+                    'itemtype',
                 ],
-                'FROM' => `glpi_plugin_order_orders_items`,
+                'FROM' => 'glpi_plugin_order_orders_items',
                 'WHERE' => [
-                    `plugin_order_orders_id` => $this->getID(),
+                    'plugin_order_orders_id' => $this->getID(),
                 ],
             ];
             foreach ($DB->request($query) as $infos) {

inc/order_supplier.class.php

@@ -437,10 +437,10 @@ public static function install(Migration $migration)
                 //1.5.0
                 $query = [
                     'SELECT' => [
-                        `suppliers_id`,
-                        `entities_id`,
-                        `is_recursive`,
-                        `id`,
+                        'suppliers_id',
+                        'entities_id',
+                        'is_recursive',
+                        'id',
                     ],
                     'FROM' => 'glpi_plugin_order_orders',
                 ];