Fix(core): fix relation declaration (#526)

* Fix(core): fix relation declaration

* adapt changelog

Author: stonebuzz

CHANGELOG.md

@@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 
 - Fix `Validation` tab from `Order`
+- Fix invalid relations declared
+
 
 ## [2.12.4] - 2025-12-02
 

ajax/massreception.php

@@ -62,7 +62,7 @@
 ]);
 echo "</td><td>";
 echo __s("Delivery status", "order") . "&nbsp;";
-PluginOrderDeliveryState::Dropdown(['name' => "plugin_order_deliverystates_id"]);
+PluginOrderDeliverystate::Dropdown(['name' => "plugin_order_deliverystates_id"]);
 echo "</td></tr>";
 
 echo "<tr class='tab_bg_2'>";

front/ordertype.php

@@ -30,6 +30,6 @@
 
 Session::checkLoginUser();
 
-$dropdown = new PluginOrderOrderType();
+$dropdown = new PluginOrderOrdertype();
 
 include(GLPI_ROOT . "/front/dropdown.common.php");

front/othertype.form.php

@@ -30,6 +30,6 @@
 
 Session::checkLoginUser();
 
-$dropdown = new PluginOrderOtherType();
+$dropdown = new PluginOrderOthertype();
 
 include(GLPI_ROOT . "/front/dropdown.common.form.php");

hook.php

@@ -57,14 +57,14 @@ function plugin_order_install()
     $migration = new Migration(PLUGIN_ORDER_VERSION);
     $classes = ['PluginOrderConfig', 'PluginOrderBillState', 'PluginOrderBillType',
         'PluginOrderOrderState', 'PluginOrderOrder','PluginOrderOrder_Item',
-        'PluginOrderReference', 'PluginOrderDeliveryState',
+        'PluginOrderReference', 'PluginOrderDeliverystate',
         'PluginOrderNotificationTargetOrder',
         'PluginOrderOrder_Supplier', 'PluginOrderBill', 'PluginOrderOrderPayment',
-        'PluginOrderOrderType', 'PluginOrderOther', 'PluginOrderOtherType',
+        'PluginOrderOrdertype', 'PluginOrderOther', 'PluginOrderOthertype',
         'PluginOrderPreference', 'PluginOrderProfile', 'PluginOrderReference_Supplier',
         'PluginOrderSurveySupplier', 'PluginOrderOrderTax', 'PluginOrderDocumentCategory',
-        'PluginOrderReferenceFree', 'PluginOrderAccountSection',
-        'PluginOrderAnalyticNature',
+        'PluginOrderReferenceFree', 'PluginOrderAccountsection',
+        'PluginOrderAnalyticnature',
     ];
     foreach ($classes as $class) {
         if ($plug = isPluginItemType($class)) {
@@ -122,13 +122,13 @@ function plugin_order_uninstall()
 
     $classes = ['PluginOrderConfig', 'PluginOrderBill', 'PluginOrderBillState',
         'PluginOrderBillType', 'PluginOrderOrderState', 'PluginOrderOrder',
-        'PluginOrderOrder_Item', 'PluginOrderReference', 'PluginOrderDeliveryState',
+        'PluginOrderOrder_Item', 'PluginOrderReference', 'PluginOrderDeliverystate',
         'PluginOrderNotificationTargetOrder',
         'PluginOrderOrder_Supplier', 'PluginOrderOrderPayment','PluginOrderOrderTax',
-        'PluginOrderOrderType', 'PluginOrderOther', 'PluginOrderOtherType',
+        'PluginOrderOrdertype', 'PluginOrderOther', 'PluginOrderOthertype',
         'PluginOrderPreference', 'PluginOrderProfile', 'PluginOrderReference_Supplier',
         'PluginOrderSurveySupplier', 'PluginOrderDocumentCategory',
-        'PluginOrderAccountSection', 'PluginOrderAnalyticNature',
+        'PluginOrderAccountsection', 'PluginOrderAnalyticnature',
     ];
     foreach ($classes as $class) {
         call_user_func([$class, 'uninstall']);
@@ -146,14 +146,14 @@ function plugin_order_getDropdown()
     if ($plugin->isActivated("order")) {
         return ['PluginOrderOrderTax'         => __s("VAT", "order"),
             'PluginOrderOrderPayment'     => __s("Payment conditions", "order"),
-            'PluginOrderOrderType'        => __s("Type"),
+            'PluginOrderOrdertype'        => __s("Type"),
             'PluginOrderOrderState'       => __s("Order status", "order"),
-            'PluginOrderOtherType'        => __s("Other type of item", "order"),
-            'PluginOrderDeliveryState'    => __s("Delivery status", "order"),
+            'PluginOrderOthertype'        => __s("Other type of item", "order"),
+            'PluginOrderDeliverystate'    => __s("Delivery status", "order"),
             'PluginOrderBillState'        => __s("Bill status", "order"),
             'PluginOrderBillType'         => __s("Bill type", "order"),
-            'PluginOrderAnalyticNature'   => __s("Analytic nature", "order"),
-            'PluginOrderAccountSection'   => __s("Account section", "order"),
+            'PluginOrderAnalyticnature'   => __s("Analytic nature", "order"),
+            'PluginOrderAccountsection'   => __s("Account section", "order"),
             'PluginOrderDocumentCategory' => __s("Orders", "order"),
         ];
     } else {

inc/accountsection.class.php

@@ -30,7 +30,7 @@
 
 
 
-class PluginOrderAccountSection extends CommonDropdown
+class PluginOrderAccountsection extends CommonDropdown
 {
     public static $rightname   = 'plugin_order_order';
 

inc/analyticnature.class.php

@@ -30,7 +30,7 @@
 
 
 
-class PluginOrderAnalyticNature extends CommonDropdown
+class PluginOrderAnalyticnature extends CommonDropdown
 {
     public static $rightname   = 'plugin_order_order';
 

inc/deliverystate.class.php

@@ -30,7 +30,7 @@
 
 
 
-class PluginOrderDeliveryState extends CommonDropdown
+class PluginOrderDeliverystate extends CommonDropdown
 {
     public static function getTypeName($nb = 0)
     {

inc/order.class.php

@@ -979,7 +979,7 @@ public function showForm($ID, $options = [])
         /* type order */
         echo "<td>" . __s("Type") . ": </td><td>";
         if ($canedit) {
-            PluginOrderOrderType::Dropdown([
+            PluginOrderOrdertype::Dropdown([
                 'name' => "plugin_order_ordertypes_id",
                 'value' => $this->fields["plugin_order_ordertypes_id"],
             ]);
@@ -1293,7 +1293,7 @@ public function showForm($ID, $options = [])
         }
 
         if ($canedit) {
-            PluginOrderAccountSection::Dropdown([
+            PluginOrderAccountsection::Dropdown([
                 'name'  => "plugin_order_accountsections_id",
                 'value' => $this->fields["plugin_order_accountsections_id"],
             ]);

inc/order_item.class.php

@@ -509,7 +509,7 @@ public function showAddForm($plugin_order_orders_id)
                 echo "</span></td>";
 
                 echo "<td " . ($config->isAnalyticNatureDisplayed() ? '' : 'style="display:none;"') . ">";
-                PluginOrderAnalyticNature::Dropdown(['name'  => "plugin_order_analyticnatures_id"]);
+                PluginOrderAnalyticnature::Dropdown(['name'  => "plugin_order_analyticnatures_id"]);
 
                 if ($config->isAnalyticNatureMandatory()) {
                     echo " <span class='red'>*</span>";
@@ -589,7 +589,7 @@ public function showAddForm($plugin_order_orders_id)
                     echo "</td>";
 
                     echo "<td " . ($config->isAnalyticNatureDisplayed() ? '' : 'style="display:none;"') . ">";
-                    PluginOrderAnalyticNature::Dropdown(['name'  => "plugin_order_analyticnatures_id"]);
+                    PluginOrderAnalyticnature::Dropdown(['name'  => "plugin_order_analyticnatures_id"]);
 
                     if ($config->isAnalyticNatureMandatory()) {
                         echo " <span class='red'>*</span>";
@@ -662,7 +662,7 @@ public function showAddForm($plugin_order_orders_id)
 
                     $core_typefilename   = GLPI_ROOT . "/src/" . $file . "Type.php";
                     $plugin_typefilename = PLUGIN_ORDER_DIR . "/inc/" . strtolower($file) . "type.class.php";
-                    $itemtypeclass       = "PluginOrderOtherType";
+                    $itemtypeclass       = "PluginOrderOthertype";
 
                     if (
                         file_exists($core_typefilename)