Skip to content

Commit 9f4a57d

Browse files
committed
Fix initial response to CircleRelayInitStateRequest
Add more reference comments
1 parent a2ede89 commit 9f4a57d

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

plugwise_usb/messages/requests.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,11 +1512,11 @@ class CircleRelayInitStateRequest(PlugwiseRequest):
15121512
"""Get or set initial relay state after power-up of Circle.
15131513
15141514
Supported protocols : 2.6
1515-
Response message : CircleInitRelayStateResponse
1515+
Response message : NodeAckResponse # CircleInitRelayStateResponse
15161516
"""
15171517

1518-
_identifier = b"0138"
1519-
_reply_identifier = b"0139"
1518+
_identifier = b"0138" # PWCircleGetSetInitialRelaisStateRequestV2_6
1519+
_reply_identifier = b"0100" # b"0139" # PWCircleGetSetInitialRelaisStateReplyV2_6
15201520

15211521
def __init__(
15221522
self,
@@ -1532,13 +1532,13 @@ def __init__(
15321532
self.relay = Int(1 if relay_state else 0, length=2)
15331533
self._args += [self.set_or_get, self.relay]
15341534

1535-
async def send(self) -> CircleRelayInitStateResponse | None:
1535+
async def send(self) -> NodeAckResponse | None:
15361536
"""Send request."""
15371537
result = await self._send_request()
1538-
if isinstance(result, CircleRelayInitStateResponse):
1538+
if isinstance(result, NodeAckResponse):
15391539
return result
15401540
if result is None:
15411541
return None
15421542
raise MessageError(
1543-
f"Invalid response message. Received {result.__class__.__name__}, expected CircleRelayInitStateResponse"
1543+
f"Invalid response message. Received {result.__class__.__name__}, expected NodeAckResponse"
15441544
)

plugwise_usb/messages/responses.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ class StickResponseType(bytes, Enum):
4848
# Minimal value = b"00C0", maximum value = b"00F3"
4949
# Below the currently known values:
5050

51-
ACCEPT = b"00C1"
52-
FAILED = b"00C2"
51+
ACCEPT = b"00C1" # HN_OK
52+
FAILED = b"00C2" # HN_COMMAND_INVALID
5353
COMMAND_NOT_ALLOWED = b"00C3"
5454
CANNOT_JOIN_NETWORK = b"00C4"
5555
NODE_CHANGE_ACCEPTED = b"00C7"
@@ -80,8 +80,8 @@ class NodeResponseType(bytes, Enum):
8080
class NodeAckResponseType(bytes, Enum):
8181
"""Response types of a 'NodeAckResponse' reply message."""
8282

83-
DEFAULT_ACK= b"00A0"
84-
DEFAULT_FAIL = b"00A1"
83+
DEFAULT_ACK= b"00A0" # HN_DEFAULT_ACK
84+
DEFAULT_FAIL = b"00A1" # HN_DEFAULT_NACK
8585
SENSE_INTERVAL_ACCEPTED = b"00B3" # HN_ACKSETSENSEINTERVAL_ACK
8686
SENSE_INTERVAL_FAILED = b"00B4" # HN_ACKSETSENSEINTERVAL_NACK
8787
SENSE_BOUNDARIES_ACCEPTED = b"00B5" # HN_ACKSETSENSEBOUNDARIES_ACK

0 commit comments

Comments
 (0)